Bug 14468 – iTunes import crashes on REPLAYGAIN_TRACK_GAIN for remote tracks

Bug 14468 - iTunes import crashes on REPLAYGAIN_TRACK_GAIN for remote tracks

Summary:

iTunes import crashes on REPLAYGAIN_TRACK_GAIN for remote tracks

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	iTunes
Version:	7.4.0
Platform:	PC Other

Importance:	P1 major with 1 vote (vote)
Target Milestone:	7.4.1
Assigned To:	Alan Young

URL:	http://forums.slimdevices.com/showthr...
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2009-10-01 02:15 UTC by Michael Herger
Modified:	2009-10-22 11:23 UTC (History)
CC List:	3 users (show)

See Also:
Category:	Test

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Herger 2009-10-01 02:15:46 UTC

Andy/Alan - don't know who fixed this similar issue as reported then by MCuson. But there seems to be another occurence where the scanner is trying to read som inexistent property from a remote track:

[09-09-30 05:28:23.0436] main::main (300) Error: Failed when running
main scan: [Can't locate object method "replaygain_track_gain" via
package "Slim::Schema::RemoteTrack" at
/<C:\PROGRA~1\SQUEEZ~2\server\scanner.exe>Slim/Schema/RemoteTrack.pm
line 208.
]

Comment 1 Andy Grundman 2009-10-01 11:37:12 UTC

I wonder if we should use AUTOLOAD to handle any other fields that might be
called, or just copy the rest of the track object methods?

Comment 2 Alan Young 2009-10-01 11:41:28 UTC

We should (now) have all the Track methods. The problem is that many of the tags get preprocessed by the routine that is not being called for remote tracks. I'm sure the answer is to call the pre-processor but I'm just not sure what the risk trade-off will be.

Comment 3 Alan Young 2009-10-02 00:18:04 UTC

I'll open a new bug for the more general use of Schema::_preCheckAttributes() for remote tracks. Bug 14508

Comment 4 Alan Young 2009-10-02 00:34:37 UTC

Update title and hours

Comment 5 SVN Bot 2009-10-02 00:41:54 UTC

 == Auto-comment from SVN commit #28736 to the slim repo by ayoung ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28736 ==

Fixed bug 14468: iTunes import crashes on REPLAYGAIN_TRACK_GAIN for remote tracks 
Map attribute names for REPLAYGAIN_TRACK_GAIN & REPLAYGAIN_TRACK_PEAK.

Reviewed by Michael.

Comment 6 James Richardson 2009-10-02 04:13:05 UTC

*** Bug 14497 has been marked as a duplicate of this bug. ***

Comment 7 James Richardson 2009-10-22 11:23:22 UTC

This bug has been marked as fixed in the 7.4.1 release version of SqueezeBox
Server! 

Please see the Release Notes for all the details:
http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from
http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with
your new comments and we'll have another look.