Bug 13885 - Default skin can't set favorite with parser
: Default skin can't set favorite with parser
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.4.0
: PC Windows Vista
: P1 normal (vote)
: 7.4.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-06 04:19 UTC by Adrian Smith
Modified: 2009-10-06 13:16 UTC (History)
1 user (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Smith 2009-09-06 04:19:09 UTC
The default skin does not appear to use the code in S:W:Xmlbrowser to set favorites.  Because of this is it not setting favorites including the parser which is necessary to play BBCiPlayer streams.  I am sure this used to work as I changed some of the code a while ago to ensure the parser was set correctly.

Michael - do you know what has changed?
Comment 1 Adrian Smith 2009-09-06 04:20:05 UTC
Michael - do you know what's changed?
Comment 2 Michael Herger 2009-09-07 00:45:45 UTC
Don't know. It's still using the same request to favcontrol.html

'plugins/Favorites/favcontrol.html?url=' + url + '&title=' + title + '&player=' + player
Comment 3 Adrian Smith 2009-09-07 10:28:28 UTC
Well its never going to be able to set a parser that way - did xmlbrowser use to do it using the standard handler and move over to this?
Comment 4 Adrian Smith 2009-09-07 14:06:45 UTC
caused by change in bug 13557
Comment 5 SVN Bot 2009-09-08 02:38:26 UTC
 == Auto-comment from SVN commit #28459 to the slim repo by michael ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28459 ==

Fixed Bug: 13557
Fixed Bug: 13885
Description: refactor XMLBrowser play/add/favorites buttons to use common javascript. Use XMLBrowser's own favorite handler instead of the global handler, as some additional parsing might be needed.

Adrian - could you please test these and re-open if needed? Thanks!
Comment 6 Adrian Smith 2009-09-08 13:41:19 UTC
Yes working as intended (by me!)
Comment 7 James Richardson 2009-10-06 13:16:52 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.