Bug 13557 - Can't add more than one favourite from a search
: Can't add more than one favourite from a search
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.4.0
: PC Windows XP
: P1 normal (vote)
: 7.4.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-21 08:06 UTC by Paul Mackenzie
Modified: 2009-10-05 14:36 UTC (History)
1 user (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Mackenzie 2009-08-21 08:06:59 UTC
Hi there,

I'm running 7.4-28228. I have been playing around with favourites and found a bug in the web interface. I did a search for 'BBC Radio' with the intention of adding BBC Radio 1 thru 6 to my favourites. From the search results screen I clicked on the heart icon (save) and added BBC Radio 1 to my favourites. I then tried to add BBC Radio 2 but doing the same thing but instead of adding the channel I get a blank screen with 'no results for' on it.

Paul
Comment 1 James Richardson 2009-08-21 10:22:52 UTC
QA confirmed
Comment 2 SVN Bot 2009-08-24 05:18:24 UTC
 == Auto-comment from SVN commit #28252 to the slim repo by michael ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28252 ==

Fixed Bug: 13557 +1.5
Description: use JS to set/reset favorites, otherwise reloading the page would invalidate the urls stored with the favorite icon.
Comment 3 Adrian Smith 2009-09-07 14:05:46 UTC
Bug: 13885

Michael - its this change which breaks adding a parser or icon from xmlbrowser to favorites.  I think we need to use the xmlbrowser handler, not the js handler unless it is extended to add parsers and icons...
Comment 4 Michael Herger 2009-09-07 23:25:17 UTC
need to fix this with respect to bug 13885
Comment 5 SVN Bot 2009-09-08 02:38:25 UTC
 == Auto-comment from SVN commit #28459 to the slim repo by michael ==
 == https://svn.slimdevices.com/slim?view=revision&revision=28459 ==

Fixed Bug: 13557
Fixed Bug: 13885
Description: refactor XMLBrowser play/add/favorites buttons to use common javascript. Use XMLBrowser's own favorite handler instead of the global handler, as some additional parsing might be needed.

Adrian - could you please test these and re-open if needed? Thanks!
Comment 6 James Richardson 2009-10-05 14:36:19 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.