Bug 13067 - Holding power button down for 2 seconds does not turn Baby off
: Holding power button down for 2 seconds does not turn Baby off
Status: RESOLVED FIXED
Product: SB Radio
Classification: Unclassified
Component: Buttons/Knob
: Include FW version in comment
: PC Windows XP
: P1 critical (vote)
: MP
Assigned To: Richard Titmuss
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-26 22:01 UTC by Mickey Gee
Modified: 2009-09-08 09:16 UTC (History)
6 users (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mickey Gee 2009-07-26 22:01:21 UTC
The Baby Boom Quick Start Guide's Troubleshooting section refers to a reset of Baby by holding down the power button on front. I don't recall reading that, but the CXR team reports that that's what it says.

Here's the quote from the CXR team:

"...Your explanation of doing a hardware reset is different from what we have in the QSG. In the QSG, we ask the user to hold the power BUTTON and then press it again and not the unplug the cord like you suggested. This is a BIG problem and we must address before MP."

Maybe I just didn't know we can do that too, but the CXR team reports that holding down the power button doesn't work as expected.

Marking this one for discussion and as an MP issue.
Comment 1 Richard Titmuss 2009-07-27 01:48:06 UTC
This is a problem, the QSG is wrong. Holding the power button, then pressing it again would be a very bad way to do a factory reset.
Comment 2 Richard Titmuss 2009-07-27 01:49:30 UTC
Oh, do they mean just a hardware power cycle. If so that's not so bad, but Caleb will need to implement in the msp430.
Comment 3 Chris Owens 2009-07-27 09:08:26 UTC
QSG says "reboot" so this function just needs to be added.
Comment 4 Mickey Gee 2009-07-27 10:54:25 UTC
Had a chat with Randy and Caleb. We reread was stated in the QSG in the "Troubleshooting" section:

"REBOOT YOUR SQUEEZEBOX RADIO

To reboot your Squeezebox Radio, press and hold the Power button until the unit turns off; then touch the Power button to restore power.

FACTORY RESET YOUR SQUEEZEBOX RADIO

To factory reset your Squeezebox Radio, press and hold the Power button until the unit turns off; then touch the Power button to restore power. Immediately press and hold the More button until a "Factory Reset" message appears on the screen.

Alternatively, go to Home>Settings>Advanced>Factory Reset>Continue...."

According to Caleb, Dean says there should be two modes of powering off Baby:

Mode 1: Momentary press of Power button: Puts Baby into Standby. Screen off, but not really off.
Mode 2: Hold down Power button for more than 2 seconds: Baby is powered off.

The current method of pull power cord-hold down "+"-insert power cord-release "+" button will not work if Baby has a battery in it, so it's likely that Dean wanted Mode 2 above to work in all cases.

Although it may not be easy for the user to distinguish which one has occurred (maybe screen displays something similar to Jive before powering down?), a factory reset will occur only after Baby is in Mode 2. Holding down "+" while turning on Baby in this mode will perform a factory reset.

Caleb says that Mode 1 is already implemented, and that all that needs to be done to make this work is to implement Mode 2. He's committed to implementing this for MP firmware as part of his work on MCU firmware. Although this work is related to bug 12280, it's not the same.
Comment 5 Mickey Gee 2009-07-27 10:56:46 UTC
In summary, the results of Comment 4 are:

1. No change to QSG
2. Caleb to change firmware to match QSG for MP.
Comment 6 Caleb Crome 2009-07-28 22:21:46 UTC
*** Bug 12280 has been marked as a duplicate of this bug. ***
Comment 7 Caleb Crome 2009-07-30 10:11:04 UTC
Okay, I have the MSP code implemented, but I'm still not sure the QSG description is going to be sufficient.

Here's why:

There are 2 'off' states.  stand-by and *OFF*. 

When you press the power button, it turns off immediately. Screen goes blank.  However, this is only stand-by mode.

To go *OFF* you need to press-and-hold the power button for 5 seconds.  We can change this timeout to whatever we like, but this will make it off-off.  

That's the mode where factory reset works.

The language should be:

"To factory reset your Squeezebox Radio, press and hold the Power button for 10 seconds, then release the power button.  Then press-and-hold the More button, then press the power button for 1 second and release.  Keep holding the More button until you see the Logitech logo."  Alternatively, simply press and hold 'More' while plugging in the power cable.  Keep pressing More until the Logitech logo appears.

The instructions as printed are not correct, because as far as the user is concerned a 'tap' is the same as 'press-and-hold' -- they appear 'off'.

Somebody.... What's the correct behavior?  I don't think we can make it work as the QSG says.
Comment 8 Caleb Crome 2009-07-30 18:15:56 UTC
MSP430 code fixed in rev 6757.  However, the way the UI looks needs to get updated.  The MSP code shuts down after 5 seconds of press and hold, but the screen goes dark after only 2 seconds or so.

Richard, who should this go to?
Comment 9 Mickey Gee 2009-07-30 20:58:46 UTC
Here the general thoughts of some people in QA regarding how this should work. Subject to tweaks, of course ....

- After 2 seconds, the screen state is compliant with definition in Settings->Screen->When Off
- After 5 seconds, screen shows graphic similar to Jive's Goodbye screen when Power button is held down. Perhaps even plays music similar to Jive, too.

No consensus in Mt. View whether this behavior is required for MP, but definitely required for first release.
Comment 10 Mickey Gee 2009-07-31 10:52:33 UTC
For Boom, here's what the Power button does:

- Press button momentarily to bring up default clock display
- Hold button down for 3 seconds to reset Boom

James thinks Baby should be just like Boom, with the addition of the OFF functionality that's been discussed.

There's been discussion about making turning Baby OFF after holding down the Power button for 10 seconds instead of just 5. Informally asking people around here there's a preference for 5 seconds. However, the difference between 3 and 5 seconds is minimal and perhaps hard to differentiate.
Comment 11 Richard Titmuss 2009-07-31 13:24:47 UTC
It works like this:
* press power and it turns off (goes to off screensaver)
* hold power for 2 seconds, you get the tune and it shuts down
* hold power for 10 seconds, emergency power off in the mcu in case the apps crashed

Implemented in baby-mp in r6870, will be merging to fab4 branch soon.