Bug 1305 - implement bass and treble equalizing options for sb2
: implement bass and treble equalizing options for sb2
Status: RESOLVED WONTFIX
Product: SB 2/3
Classification: Unclassified
Component: Audio
: unspecified
: All All
: P4 enhancement with 13 votes (vote)
: Future
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-04-04 14:18 UTC by Kevin Pearsall
Modified: 2008-06-02 11:36 UTC (History)
6 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Pearsall 2005-04-04 14:18:43 UTC
 
Comment 1 Fred 2005-05-17 18:34:43 UTC
For the moment sb2 has min/max bass/treble/pitch at 0/0. But Client.pm defaults to 50. In the CLI, the 
first query returns 50, and if a change is attempted this drops to 0. *Very* strange behaviour...
I wonder if the min/max defaults in client.pm (50/50) could be used instead: at least it would stay at 
50!

Is this planned to be fixed soon or should I document it in the CLI ?
Comment 2 Blackketter Dean 2005-08-19 22:06:02 UTC
*** Bug 818 has been marked as a duplicate of this bug. ***
Comment 3 Tim Miller 2005-10-20 20:33:57 UTC
Bass / treble control isn't a feature of the SB2? Removed from the SB1?
Comment 4 KDF 2005-10-20 23:04:58 UTC
This report has Product selected as "Squeezebox2".  This means it has nothing to
do with the SB1, which remains at FW v40 with all features that it has always
had.  If you try to use the bass/treble controls through slimserver with a
Squeezebox2, you will find that they do nothing, and in fact lock to zero.  This
is what this bug report is about.
Comment 5 Tim Miller 2005-10-21 00:38:41 UTC
Sorry I was unclear.  What I meant to say is that as a new SB2 owner it is
disappointing to learn it doesn't have equalization controls... controls that
the SB1 seems to have.  Is the SB firmware open-source?  Alternatively, is it
feasible to implement tone controls in SlimServer?
Comment 6 KDF 2005-10-21 08:48:44 UTC
the tone controls are already in place in slimserver but require firmware-side
support.  no, the firmware is not open. the licensing from the ccpu vendor does
not allow for it.
Comment 7 Jonathan Perry 2005-10-21 11:44:39 UTC
It's a shame this enhancement is low priority.   Many people seem to be using a
sonic T-Amp straight to a pair of speakers, leaving no room for any tonal
adjustment.  One of my SB's is set up as above with a pair of speakers sat on
kitchen cupboards.  The bass is excessive to say the least  :0

Anyway, my 2pence
Comment 8 KDF 2005-11-13 11:18:21 UTC
*** Bug 2550 has been marked as a duplicate of this bug. ***
Comment 9 Michael Wagner 2005-12-18 10:03:39 UTC
This bug is Assigned To:  Vidur Apparao <vidur@slimdevices.com>, who no longer works for Slim. Is that why it isn't getting any attention?
Comment 10 Tom R. Loden 2005-12-19 06:44:59 UTC
From 2550: "bass and treble control is not implemented for SB2, so the UI is showing the only value that exists for SB2."

I either don't understand the comment or don't believe it.

With the Touch skin, you can adjust the bass/treble fine and it shows up exactly perfectly in the slim.pref file with the correct values (0-100? can't remember). If nothing else, there is a bug in the Fishbone skin.

Whether or not it has any effect in the SB is a question I haven't completely done my home work on just yet. I do know that it has SOME effect. The bass does indeed get diminished when bass=0. I will try to get more specific results this week.
Comment 11 KDF 2005-12-19 09:45:15 UTC
the tone controls are gone from the fishbone skin.
Comment 12 Michael Wagner 2005-12-19 18:59:09 UTC
Now I'm totally confused as to what is broken and what is working with tone controls and squeezeboxen. When time permits, probably between xmas and NYE, I will test this from the CLI, removing at least the skin question from the equation. I now have both SB1s and SB3s, which covers the major hardware issues.
Comment 13 Michael Wagner 2005-12-19 19:09:06 UTC
(In reply to comment #11)
> the tone controls are gone from the fishbone skin.

They are there in 6.2.0
Comment 14 Michael Wagner 2005-12-19 20:05:56 UTC
OK. I think this bug report has drifted from it's initial wording. Frederic first reported an anomoly in Client.pm. But the problem is bigger:

If you compare squeezebox.pm and squeezebox2.pm, the "2" version contains the following stub routines: 
sub maxBass {0};
sub minBass {0};

Same for min and max Treble, and min and max Pitch.

So I don't know if the hardware can't support these things, but surely the perl routines that drive the hardware don't support these things.

If I ask, at the CLI, what the bass or treble level is, I get back the string "level" (without the quotes). I assume something is going wrong somewhere, but I don't know where.

If I set (at the CLI) the bass (or treble) level to some number, like 50, I get back the echo as 50, but afterwards, when I ask, it's actually been set to 0.

This is presumably the curiosity in client.pm, reported by Frederic. 

To summarize:
If the SB2/3 can support bass, treble & pitch, then this is an upgrade request that the squeezebox2.pm code should be written to implement it.
If the SB2/3 cannot currently support bass, treble & pitch, then this is an upgrade request to change the SB2/3 firmware to support them, and then support them in squeezebox2.pm in the server.

And if it remains, I guess the client.pm and CLI inconsistancies should be cleared up too. :-)
Comment 15 Fred K 2006-01-05 11:17:29 UTC
I don't know....maybe I'm crazy, BUT in addition to simple Treble and Bass (which I think should definitely be available under player settings) is it possible to include an equalizer OR better yet a player plug-in area, where one can sample the acoustic characteristics of a specific tube preamp to give their SB3 this specific �sound�.

Isn�t it only a matter of time?

Just a thought, Fred in Canada 

Comment 16 KDF 2006-01-05 11:27:47 UTC
fred, see bug 2133, and bug 729 for requests related to this.
Comment 17 Michael Wagner 2006-01-05 11:35:57 UTC
(In reply to comment #15)
> in addition to simple Treble and Bass (which I think should definitely be available under player settings) is it possible to include an equalizer OR better yet a player plug-in area, where one can sample the acoustic characteristics of a specific tube preamp to give their SB3 this specific �sound�.

At the moment, there is no firmware support in the SB2/3 for tone modification. This enhancement request is meant to address that issue. How flexibly it is implemented in the server afterwards is a (comparatively) easier issue to address, once the firmware support is there.
Comment 18 Tom R. Loden 2006-01-08 07:41:26 UTC
I finally had a moment to debug this thing a bit. 

Conclusions:

   1. The Fishbone Skin is broken. 
   2. Squeezebox (not SB2 or SB3) supports tone adjustments.

Recommed:

   1. The Priority and Severity be increased.

I don't know where to go with this, but it's not just an enhancement. The reason I'm pushing for this fix relates to the fact that I spent 30 minutes trying to "un-screw up" the tone controls after "mis-clicking" in Fishbone and having to listen to "crap" for those 30 minutes. Here are my results of this morning's test (if too terse, I can add more detail):

#
# Initially - Using Touch skin (web interface)
# 
# In the Current Song window, there are 10 rectangles next to "BASS" and 
# "TREBLE" at the bottom of the screen. Settings listed here are in terms
# of which rectangle.
#
# bass is at the 5th out of 10 rectangles 
# treble is at the 5th out of 10 rectangles 
#
# The slimserver.pref values show up after a web page reload.
#

host:~/c/Program Files/SlimServer/server> grep -i bass slimserver.pref
    bass: 50
host:~/c/Program Files/SlimServer/server> grep -i treble slimserver.pref
    treble: 50

host:~/c/Program Files/SlimServer/server> # set bass at 10/10 in browser
#
# Music sounds "too bassy" (do I need to attach sound samples?) 
#
host:~/c/Program Files/SlimServer/server> grep -i bass slimserver.pref
    bass: 100

host:~/c/Program Files/SlimServer/server> # set treble at 10/10 in browser
# 
# Music sounds "too tinny"
#
host:~/c/Program Files/SlimServer/server> grep -i treble slimserver.pref
    treble: 100

host:~/c/Program Files/SlimServer/server> # set treble to 7/10 in browser
host:~/c/Program Files/SlimServer/server> grep -i treble slimserver.pref
    treble: 80

host:~/c/Program Files/SlimServer/server> # set bass to 7/10 in browser
host:~/c/Program Files/SlimServer/server> grep -i bass slimserver.pref
    bass: 80

host:~/c/Program Files/SlimServer/server> # set bass to 6/10 in browser
host:~/c/Program Files/SlimServer/server> # set treble to 6/10 in browser
host:~/c/Program Files/SlimServer/server> grep -i bass slimserver.pref
    bass: 70
host:~/c/Program Files/SlimServer/server> grep -i treble slimserver.pref
    treble: 70

host:~/c/Program Files/SlimServer/server> # set treble to 5/10  in browser
host:~/c/Program Files/SlimServer/server> # set bass to 5/10  in browser
#
# Music sounds "good"
#
host:~/c/Program Files/SlimServer/server> grep -i treble slimserver.pref
    treble: 50
host:~/c/Program Files/SlimServer/server> grep -i bass slimserver.pref
    bass: 50
Comment 19 KDF 2006-01-08 11:51:09 UTC
the tone controls are no longer part fo the fishbone skin in nightly builds.
Comment 20 Michael Wagner 2006-01-08 12:34:14 UTC
(In reply to comment #19)
> the tone controls are no longer part fo the fishbone skin in nightly builds.

Which solves the odd behaviour of fishbone, but doesn't really address the underlying issue, that is, there is no support for tone controls in SB2/3.
Comment 21 Barry Caruth 2007-03-09 01:45:30 UTC
I've just hooked a SB3 up to some active speakers which are very bass heavy. I really need a way to tweak the bass output from the SB3.
Comment 22 Chris Owens 2008-06-02 11:36:31 UTC
we're out of CPU on the sb2/3 platform