Bug 12844 - power button occasionally double-submitting events
: power button occasionally double-submitting events
Status: RESOLVED WORKSFORME
Product: SB Radio
Classification: Unclassified
Component: Menus
: Include FW version in comment
: PC Other
: P3 normal (vote)
: 7.4.0
Assigned To: Ross Levine
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-14 06:04 UTC by Wadzinski Tom
Modified: 2010-05-27 14:45 UTC (History)
5 users (show)

See Also:
Category: Bug


Attachments
Fix for bouncing baby buttons (6.10 KB, patch)
2009-07-16 10:48 UTC, Caleb Crome
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wadzinski Tom 2009-07-14 06:04:02 UTC
While examiining http://forums.slimdevices.com/showthread.php?t=65502
and using evtest I noticed that on my baby i frequently get two up/down sequences when I do a sloppy press of the baby power button. So far in my testing other buttons don't seem to have the same problem.
Comment 1 Blackketter Dean 2009-07-15 22:52:12 UTC
I see this too.
Comment 2 Richard Titmuss 2009-07-16 08:46:54 UTC
We need to understand this for MP.
Comment 3 Caleb Crome 2009-07-16 10:47:55 UTC
I think I found the issue with this.  It's that the button could be bouncing exactly when the debounce timer runs out.

The attached patch fixes the problem... I think.  Needs more testing.
Comment 4 Caleb Crome 2009-07-16 10:48:38 UTC
Created attachment 5480 [details]
Fix for bouncing baby buttons
Comment 5 Caleb Crome 2009-07-16 11:15:12 UTC
*** Bug 12367 has been marked as a duplicate of this bug. ***
Comment 6 Richard Titmuss 2009-07-16 11:35:27 UTC
Fixed in baby-mp r6622, merged to fab4 r6623.
Comment 7 Ross Levine 2009-07-24 17:35:59 UTC
There is one power button issue I'm seeing that makes me feel like this may not be fixed. About 10% of the time I press the power button while streaming music, the music stops but it just pauses the music. Makes me think a double press is happening and it's being turned off and then back on into pause mode very quickly.
Comment 8 Mike Cappella 2009-08-05 18:21:59 UTC
I've reopened this because I just saw this with 6930, in case anyone is interested.

The double bounce occurred when I selected Continue wrt. to connecting to mysqueezebox.com.
Comment 9 Ben Klaas 2009-08-26 07:52:17 UTC
this is an administrative shuffle on priority fields to help make better judgment on the top end of the priority list. P4->P5, P3->P4, and P2->P3.
Comment 10 James Richardson 2009-08-26 09:36:29 UTC
This appears to be much improved in r7261, please retest with that version and provide feedback.
Comment 11 Ross Levine 2009-08-28 16:51:56 UTC
(In reply to comment #10)
> This appears to be much improved in r7261, please retest with that version and
> provide feedback.

I agree, I haven't been able to reproduce this since 7261. Mike, have you seen it?

Resolving this, lets re-open if anyone sees it again.
Comment 12 Chris Owens 2010-05-27 14:45:57 UTC
These bugs have all been marked resolved and belong to a component which is being removed.  Therefore they have been moved to the most applicable of the new components.