Bug 11808 - 'Add Alarm' does not work
: 'Add Alarm' does not work
Status: RESOLVED DUPLICATE of bug 13146
Product: SqueezePlay
Classification: Unclassified
Component: Browser
: unspecified
: PC Windows XP
: P1 normal (vote)
: 7.4.0
Assigned To: Ben Klaas
: CAT
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-15 10:16 UTC by James Richardson
Modified: 2009-09-08 09:21 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Richardson 2009-04-15 10:16:52 UTC
CAT PR-0100  r5265

I went to test the Alarm function and was shocked to find a full text keyboard when simply adding a time set alarm. This seems way overcomplicated and I was going to submit as simply a suggestion to modify to only allow numbers or arrows to move numbers but then I discovered that the text keyboard does not even work. I tried to switch over to numbers and enter a time for an alarm and it would not allow me to do so. I added 2 numbers and then it wouldn't let me enter anything else.. nor would it let me erase the numbers which I had typed in with backspace and/or the arrows.
Comment 1 Pikeharmony 2009-05-25 04:59:13 UTC
The Add Alarm function is causing the fab4 to reboot the unit.

In one case it killed the unit


http://forums.slimdevices.com/showthread.php?t=63693
Comment 2 Wadzinski Tom 2009-06-02 04:32:26 UTC
Ben, this seems to be related to r5425, but it's not clear to me what the solution is. In the Add alarm case, here is the json:
                         {
                           actions    => {
                                           "do" => {
                                                 cmd => ["alarm", "add"],
                                                 params => { enabled => 1, "time" => "__TAGGEDINPUT__" },
                                                 player => 0,
                                               },
                                         },
                           input      => {
                                           _inputStyle => "time",
                                           help => {
                                                 text => "Use the scroll wheel to change clock digits, then press the center button to select that digit. Press the center button after time is entered to set the alarm time.",
                                               },
                                           initialText => 0,
                                           len => 1,
                                         },
                           nextWindow => "parent",
                           text       => "Add Alarm",
                           window     => { titleStyle => "settings" },



len is > 0, so  the "if tonumber(inputSpec.len) > 0" check will switch the input type from timeValue to textValue, resulting in a blank inputValue. If it's really supposed to switch over to a textValue, perhaps it should be textValue(tostring(v), tonu...)? That works, but not sure it that's what's intended.

	if inputStyle == 'time' then
		if not initialText then
			initialText = '0'
		end
		local timeFormat = _getTimeFormat()
		local _v = DateTime:timeFromSFM(v, timeFormat)
		v = Textinput.timeValue(_v, timeFormat)
	elseif inputStyle == 'ip' then
		if not initialText then
			initialText = ''
		end
		v = Textinput.ipAddressValue(initialText)
	end

	local inputValue
	if tonumber(inputSpec.len) > 0 then
		inputValue = Textinput.textValue(v, tonumber(inputSpec.len), 200)
	else
		inputValue = v
	end
Comment 3 Ben Klaas 2009-06-02 07:25:41 UTC
The problem goes pretty deep on Fab4, in that we haven't really accounted for time value input when using the new-in-Fab4 Keyboard widget. This will not be an easy complete fix, but needs to happen prior to release.

What needs to happen today is a workaround so the crash doesn't happen. I'll see what I can do right away for that.
Comment 4 Ben Klaas 2009-06-02 07:54:51 UTC
r5960 fixes the crasher.

lots of work to be done to make alarms work properly with the Fab4 keyboard. Bug remains open and alarm configuration is basically inoperable at this time.
Comment 5 Pikeharmony 2009-06-03 05:44:44 UTC
We it's working now see my post.

http://forums.slimdevices.com/showthread.php?t=63833


Interface is hard can't set the time correctly with the keyboard.

THe alarm interface needs to be changed.


Some examples we can use

http://z.about.com/d/ipod/1/0/e/3/-/-/iphone_gallery_10.jpg

http://pocketables.typepad.com/photos/uncategorized/2008/02/17/samsung_s5_alarm.jpg
Comment 6 Ben Klaas 2009-08-03 07:46:17 UTC
this is basically a dup of 13146 at this point

*** This bug has been marked as a duplicate of bug 13146 ***