Bug 11768 - Consolidate copying and verifying firmware into one step
: Consolidate copying and verifying firmware into one step
Status: RESOLVED FIXED
Product: SB Touch
Classification: Unclassified
Component: UI
: unspecified
: All All
: -- minor (vote)
: MP
Assigned To: Richard Titmuss
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-11 16:00 UTC by Jim McAtee
Modified: 2009-09-08 09:31 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2009-04-11 16:00:27 UTC
In my experience, the way the Fab4 presents the firmware update process is a bit unusual.  The typical upgrade process with most consumer network devices presents this as a single step.  I feel that you should make it as familiar as possible for the typical user.

Functionally identical.  Just presented differently.
Comment 1 Mark Miksis 2009-04-11 16:19:02 UTC
Not quite a dupe, but related to bug 10642.
Comment 2 Blackketter Dean 2009-04-11 16:50:36 UTC
I think it makes sense to explain to the user that it's downloading, which gives them a sense for how long it might take.  Verifying would be a separate step, which shouldn't take long at all.  

So maybe we just call it Downloading and then Verifying?

What do you think, Matt?
Comment 3 Jim McAtee 2009-04-11 17:05:51 UTC
I don't quite follow the logic, but if it must be two steps, how about Downloading and then Installing?
Comment 4 Blackketter Dean 2009-04-11 17:24:35 UTC
I prefer showing the "Downloading" part separately, "Installing" isn't exactly correct, but is more understandable.
Comment 5 Weldon Matt 2009-04-11 19:54:15 UTC
Totally fine with this, I agree the language is more familiar to typical users...
Comment 6 Ben Klaas 2009-04-13 08:56:12 UTC
EN strings changed in r5289 to "Downloading" and "Installing". Other languages will remain as is through MP.
Comment 7 Richard Titmuss 2009-04-14 00:30:53 UTC
Just to be clear about how this actually works, the "downloading" stage downloads _and_ saves the upgrade to flash. "verifying" performs a checksum on the image in flash to confirm it's ok before rebooting.

The new names are not correct, and could be misleading in the case of an error. I don't really care about this, but if someone does  they should reopen the bug.
Comment 8 Jim McAtee 2009-04-14 00:40:25 UTC
(In reply to comment #7)
> Just to be clear about how this actually works, the "downloading" stage
> downloads _and_ saves the upgrade to flash. "verifying" performs a checksum on
> the image in flash to confirm it's ok before rebooting.

What happens if the checksum fails?  Does it somehow retain the old firmware or does the unit potentially become a brick?
Comment 9 Blackketter Dean 2009-04-14 07:41:27 UTC
JJ: fyi- like on Controller, Fab4 retains two copies of the firmware update images, so in the case of some corruption, the previous version is always available.
Comment 10 Jim McAtee 2009-04-14 12:26:28 UTC
(In reply to comment #9)
> JJ: fyi- like on Controller, Fab4 retains two copies of the firmware update
> images, so in the case of some corruption, the previous version is always
> available.

Then I would contend that "installing" for the second phase is technically correct, as well as more understandable.  It's not installed until both verified and then switched to.  To the end-user, whether the image has been loaded into flash is incidental until it's actually put into use.