Bugzilla – Bug 11566
Keyboard done button needs feedback after it is press (maybe the spinny)
Last modified: 2011-01-17 09:10:23 UTC
If the server connection is down, then when you press done it just looks like the screen does not work. We need to make some 'working' feedback on this screen. My suggestion would be to replace the Done text with a small spinny, indicating we are working. If the connection is down this screen will be visible for 30 seconds before the connection times out, so some feedback is needed. Dean, comments? Ben I can help implement this if needed. (see bug 11474).
Thinking about it, after bug 1151 and bug 11457 are fixed this change becomes easy, as it's just a style modifier for the done button.
skin support is in, as well as changing the done button in Keyboard.lua to a group of an icon and text label. however, the entire feature is not complete and won't be in for MP. I'm going to drop this in Tom's lap since he's been working on that side of it. Tom, you might want to save off an incremental patch here so you don't lose what you've been working on. retarget for CRX punt!
Shouldn't you always move off of the keyboard after 'done'? Any error messages will have to be displayed in a new window, so that would be the place to show a spinny.
An intermediate spinny screen would be nice but vetoed, not really sure why... Status: My current challenge with this is that for SN registration (and any SlimBrowser based Textinput), there isn't a way currently to cancel out of a textinout done callback in the same way that it works for Menu. SO I can lock all interaction on a keyboard, make the spinny appear, but when you re-enable input with back, the next window will eventually pop on-screen because SlimBrow isn't cancelling it. Todos: 1) tie in the canceling code 2) Understand an issue with switching style from an icon to text when the first style had test hidden = 1 cause the second style change to make nothing apear at all (switching the first style back to text hidden = 0 makes the second style work, oddly.
Reset priority before triage.
Tom, can we address this in 7.5?
After looking at this a bit, I see a couple things that suggest this is not a P1: 1) The original complaint is already fixed ( if server down, "connecting to <server>" appears. 2) The various options are yet decided, and none of them are easy. 3) This won't often come up. If the server is up the types of command where textinput is used other than search, will generally returnh quickly. In the search case, we already bring up a fullscreen "Searching" spinny. Hmm, actually, only My Music works this way. I'll look into having the other searches work this way as well...
== Auto-comment from SVN commit #29055 to the slim repo by tom == == https://svn.slimdevices.com/slim?view=revision&revision=29055 == Bug: 11566 +3 Description: - Show full screen Searching spinny on all searches, not just My Music.
See comment #7 Moving to P3, since now all searches shows the intermediate spinny.
Moving lower-priority bugs to next target
Tom is no longer available to us