Bugzilla – Bug 11551
"done" and "space" are hardcoded in Keyboard.lua
Last modified: 2009-09-08 09:11:39 UTC
unfortunate oversight: "done" and "space" are hard-coded in Keyboard.lua so will show up as such for any language. Richard, is there any issue with having a jive.ui class query for currently selected language? Michael, do you know if these strings can be poached from elsewhere? If so, do "done" or "space" take up 15 characters in Italian?
SLT - I guess these are two pretty common words. Would you have them in one of your memories already?
assigning to Richard for comment on button text localization
Hmm, breaks the model as UI code is not meant to use strings! So we have two options: 1. Everywhere the uses a keyboard needs to set the 'done' and 'space' strings into the keyboard widget. 2. Add a Framework:string() function that can use the global strings table. The first option does not appeal, so it looks like Framework will need to allow access to the global strings table. The global strings in JiveMain should also be refactored to use this mechanism. I may look at this later.
While fixin bug 11457 (changing '?' icon to 'help' label), it becomes clear that we need to be able to control if widgets are icons or text from the skin, and not the code. The skin should also be able to set a default text value of the widget. After this change this means the localized content would come from the skin. Just got to work this out, then the keyboard part of the fix should be easy.
Created attachment 5010 [details] patch to allow localized keyboard keys
Patch for Ben to review. This adds localization for keyboard keys via the skin.
Patched checked in in r5040. Just the translations needed now.
Michael, can you assist in getting us translations for these two strings?
Added a few more translations. Please note that there was already a KEYBOARD_DONE. I've copied those strings to SMALL_ENTER (which is being used as the "done" key). Still missing "space". I added a German "Leerzeichen", because it's long enought to break potentially too small keys. François - "Leerzeichen" does easily fit the space key in eg. the search dialog. Please still make sure translations for "space" aren't any longer than aobut 15 characters. Thanks!
François - any news?
SLT Team- there are currently four bugs assigned to you that have a target of "MP". The deadline for that milestone is this Wednesday April 15th. Could you update us on whether we can expect updated translations on these bugs by that date?
change 5295 - done. Thanks!
I think we're looking good here. The biggest potential issue is FR for 'done', but it fits nicely. FI for 'space' is amazingly long, but we have lots of "space for space", so that's a non-issue. closing.