Bugzilla – Bug 10319
keypad lock on controller cannot be unlocked
Last modified: 2009-06-17 09:35:56 UTC
Just upgraded to 7.3, whilst enjoying the new audio playback feature I found that after locking the controller (using add and play) I cannot unlock again. A reboot of the controller is required to get it working again. I started a thread in the squeezecenter forum about this with little response: http://forums.slimdevices.com/showthread.php?t=56271 then saw the problem mentioned in this thread: http://forums.slimdevices.com/showthread.php?t=56353 so decided to file the bug. thanks, Andy
The fix is to change the following code in Framework.lua: table.sort(listeners, function(a, b) -- stable sort, most recent first if a[3] == b[3] then return a[4] > b[4] end return a[3] < b[3] end) The comparator on a[4] and b[4] needs reversing. I need to test the screensavers to make sure these don't regress after this change before checking it in.
It also seems to take a lot of attempts to get the Controller to actually lock in the first place. The only time I managed to do it was after about 20 attempts at pressing the add and play keys, and then I couldn't unlock it and had to reset the controller.
Changing target to next release
Fixed in 7.3.2 r3692. QA please test screensavers and Key lock for regression.
Out of curiosity, if this fix was already checked into 7.3.2, why was the target milestone changed to 7.3.3?
7.3.2 is going to be an SC release only and this is a controller fix. Same goes for the browse history bug 7186. There will be a firmware pushed out to users, possibly before 7.3.3 SC is out. There is another bug that still needs fixing in the controller firmware, and rather than push out one update and then another in a short time, the decision was made to send out one, after that remaining bug is fixed. Apologies, this is a little confusing because the controller firmware doesn't have the same constraints on software release schedule as SC does. We can push out firmware to users whenever we deem appropriate, rather than the "release and announce" model.
Verified fix in r5225
This bug has been fixed in the 7.3.3 release version of SqueezeCenter! If you haven't already. please download the new version from http://www.logitechsqueezebox.com/support/download-squeezecenter.html If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.