Bug 10293 - convert.conf for ReadyNAS never updated for 7.3
: convert.conf for ReadyNAS never updated for 7.3
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Audio
: 7.3.0
: Infrant ReadyNAS RAIDiator (SPARC)
: -- major (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-12 09:30 UTC by Andy Grundman
Modified: 2009-07-31 10:33 UTC (History)
6 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Grundman 2008-12-12 09:30:30 UTC
ReadyNAS uses a different convert.conf (why?) and it needs to be synced with the real 7.3 convert.conf.
Comment 1 Andy Grundman 2008-12-12 09:33:43 UTC
I fixed the wma line in change 24290, need to check if there are any other things that need to be fixed.
Comment 2 Spies Steven 2008-12-12 11:21:55 UTC
I personally see no compelling reason not to just include the Debian based convert.conf with the ReadyNAS packages either, at least for the i386 based units.  I would think this would make maintaining the ReadyNAS package a little easier.  The current ReadyNAS convert.conf does not include any of the cahnges for new streaming either.

If a file type does not have a required binary to play it will simply be grayed out in the file types setting list, correct?
Comment 3 Andy Grundman 2008-12-13 16:01:43 UTC
Here's another issue related to this: ReadyNAS can't do FLAC+cue sheets.

http://forums.slimdevices.com/showthread.php?t=56392
Comment 4 Michael Herger 2008-12-15 01:42:10 UTC
Matt - why did we add that file anyways? Is it needed at all?

Whatever I've done to the ReadyNAS build was to fixi issues with those custom files or to remove them. I have no idea about their history and reason to be there.
Comment 5 Matt Wise 2008-12-15 06:42:00 UTC
The convert.conf was supplied by Netgear to keep users from trying to do any transcoding on the Sparc-based platforms that didn't have the horsepower. That basic requirement is still needed on those platforms -- but if we can somehow use OSDetect to do that instead, it would be much easier to manage going forward. 
Comment 6 Chris Owens 2008-12-15 10:13:34 UTC
Michael to use default convert.conf to add in line during package build to support Infrant's AAC decoder.

Matt, ReadyNAS Pro build should include the linux binaries.
Comment 7 Michael Herger 2008-12-16 01:22:27 UTC
change 24323 - use default convert.conf, but add custom-convert.conf with additional mov->wav rule to allow optimized mp4aas/aac2wav
Comment 8 Spies Steven 2008-12-16 16:22:29 UTC
The Sparc based units are not powerful enough to successfully transcode ALAC to FLAC successfully.  ALAC to WAV seems ok even though bandwidth use is increased.  Is it possible to have alac/flac disabled by default for the Sparc based ReadyNAS?  Could this be done in the custom-convert.conf?

I have not extensively tested the other server side transcoded file types but perhaps all transcoding of player supported formats should to FLAC should be disabled by default for the Sparc based ReadyNAS.
Comment 9 Michael Herger 2008-12-17 04:08:48 UTC
Why do they include flac if the box can't cope with it? The simplest and probably best "fix" for the remaining issue would be as simple as removing it.
Comment 10 Spies Steven 2008-12-17 08:55:54 UTC
FLAC is included to allow support of cue/flac files.  The original ReadyNAS provided convert.conf did not allow for flac encoding only decoding because of these performance limitations as mentioned in comment #5.
Comment 11 Michael Herger 2008-12-18 05:21:06 UTC
change 24352 - disable transcoding to FLAC on sparc based readynas
Comment 12 Matt Wise 2008-12-18 08:20:56 UTC
Michael,
  Could we have OSDetect actually do some checking on-startup that dynamically disables things based on certain specifications? For example, "if no FPU, disable ALAC->FLAC"? We could slowly start building tables of features that we disable based on certain OS and Hardware checks. From there, we could easily have a settings page that actually tells you what features have been disabled, and why. This would be great  for support to debug user problems (like, why doesnt MP3 transcoding work? check the page and sure enough it shows that Lame is missing) and also allows us to be a bit less platform specific, and more hardware/software picky. 

  (I know that Lame is a bad example because its shown in the settings already ... but if all of the 'disabled' features were in one page, it would be helpful)

Comment 13 Spies Steven 2008-12-18 14:09:59 UTC
Please disable all flac encoding on the sparc based ReadyNAS units by default.  These units do not seem to have enough power to do flac encoding without rebuffering or severely degrading the user experience.  Since this is just disabling flac encoding in file types the user still has the option to turn flac encoding back on if they so choose.

I will open a separate bug about cue/flac playback issues since that is not an option in file types.
Comment 14 Michael Herger 2008-12-19 01:54:35 UTC
Isn't this bug now covered by bug 10388?
Comment 15 Spies Steven 2008-12-19 13:33:21 UTC
Appears to be fixed in Version: 7.3.1 - 24372 and marking as such.
Comment 16 Spies Steven 2008-12-19 13:33:48 UTC
Verified with Version: 7.3.1 - 24372
Comment 17 Spies Steven 2009-01-16 09:53:19 UTC
This change does not seem to apply when the user had a previous version of SC installed.  Is it possible to force disabling of flac encoding on the sparc based units even when upgrading?  Perhaps this is related to bug 10519.
Comment 18 Michael Herger 2009-01-17 10:12:24 UTC
> This change does not seem to apply when the user had a previous version of SC
> installed.

I'm sorry I can't test right now as I've shut down my ReadyNAS at the office over the weekend. But as I haven't heard any complaints by users any more since we did this change, I'm a bit surprised you don't see this change. Did you test on a _sparc_ ReadyNAS or the Pro? Please note that this change only applies to the old NV/Duo series, but not the Pro.
Comment 19 Michael Herger 2009-01-19 00:48:41 UTC
I tested bug 10293 on my ReadyNAS this morning:

- removed the custom-convert.conf file from my installation
- restarted SC -> transcoding to flac was enabled
- downloaded and installed the latest nightly build 24695
-> transcoding to flac is disabled again (as expected), custom-convert.conf in its place


IMHO this is working as expected.
Comment 20 Spies Steven 2009-01-19 08:54:08 UTC
Michael, I had upgraded from a factory reset ReadyNAS with Netgear's SqueezeCenter build when I noticed that the AIFF and WAV file types were still set to use FLAC.

I believe the steps I took were to factory reset the ReadyNAS restoring Netgear's SqueezeCenter in the process.  Then I upgraded to SqueezeCenter 7.3. Once 7.3 was installed I upgraded to the 7.3.2 nightly.  I will try to reproduce again and note the steps I took.

This issue was actually brought to my attention by a customer who sent me a personal email.
Comment 21 Spies Steven 2009-01-19 10:59:57 UTC
Starting with a ReadyNAS after a factory reset with RAIDiator 4.1.4 will result with SqueezCenter 7.2 - 22900 installed.  I then installed SqueezeCenter 7.3.2 - 24638.  File Types were not updated for the ReadyNAS and it appears custom-convert.conf is ignored.  Perhaps a restart is required?
Comment 22 Spies Steven 2009-01-19 11:14:35 UTC
Reboot did not make a difference :(
Comment 23 Michael Herger 2009-01-19 11:17:21 UTC
Is custom-convert missing or ignored? What about permissions?
Comment 24 Spies Steven 2009-01-19 11:39:31 UTC
I'll take a look.
Comment 25 Matt Wise 2009-01-19 15:55:31 UTC
A big part of this problem was that the parabuild system was misconfigured. The sc_release_readynas_i386 and sc_release_readynas_sparc builds both were missing the --archType flag. This defaulted them to the _sparc build, and packaged them in appropriate sparc and x86 packages. I've fixed the build configs and now the packages built for release are identical to the packages built nightly. 
Comment 26 Spies Steven 2009-01-19 15:57:52 UTC
Verified fixed with both sparc and i386 ReadyNAS release candidate packages 7.3.2 - 24695
Comment 27 James Richardson 2009-01-22 09:58:33 UTC
Fixed - Closed Message (SC)

This bug has been fixed in the 7.3.3 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 28 James Richardson 2009-01-22 13:53:53 UTC
Correction: SqueezeCenter version is 7.3.2
Comment 29 Chris Owens 2009-07-31 10:33:09 UTC
Reduce number of active targets for SC