Bug 10018 - Lyrics do not display with line breaks.
: Lyrics do not display with line breaks.
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Tagging
: 7.3.0
: PC Other
: P4 normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-14 16:00 UTC by Spies Steven
Modified: 2009-07-31 10:32 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
sample file with lyrics that show double-spaced (6.70 MB, application/octet-stream)
2008-11-22 07:45 UTC, Sue Chastain
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Spies Steven 2008-11-14 16:00:35 UTC
Lyrics are no longer displayed with line breaks.  This results in the lyrics being one long run on text string.

Bug 3044 covered this in the past for 6.5.1.  I thought creating a new bug made more sense instead of reopening a bug that old but feel free to do so if you disagree.

Bug 7845 has an attachment that can be used for testing.
Comment 1 Markus Schiegl 2008-11-16 03:10:04 UTC
additional info: almost 90% of my tracks (mp3 & flac) with lyrics a properly tagged with the "LYRICS" tag, and they do display the text with line breaks in the WebUI + SBC. I've done a wipe&rescan and it still works (7.3r23938). I would have reported this long time ago :-)

Maybe it has something to do with the handling of CR and CR/LF?
Comment 2 Michael Herger 2008-11-17 00:17:49 UTC
Steven - do we have a sample file which fails displaying lyrics correctly?

Oh, and no assignee without target ;-)
Comment 3 Spies Steven 2008-11-17 11:20:38 UTC
(In reply to comment #2)
> Steven - do we have a sample file which fails displaying lyrics correctly?

I was using attachment 3240 [details] form bug 7845 like I mentioned in comment 1 ;)
Comment 4 Michael Herger 2008-11-18 06:05:51 UTC
change 23953 - fix the line breaks instead of removing them.

Haven't access to my Mac today, therefore only tested on Windows. Please test on the other platforms and re-open, if this fix doesn't work for you. Thanks!
Comment 5 Sue Chastain 2008-11-22 07:36:30 UTC
I have lyrics embedded in most of my MP3 files and I often browse these on the Controller. I am not using the Lyrics plugin, I browse them by pressing right from the Now Playing lists and then choosing Lyrics from the song info screen. 

Prior to installing 7.3 (23976), the lyrics were displayed on the controller just as I had entered them in the files. Since installing 7.3, the lyrics always have a blank line between every line of text. This is annoying and makes for way more scrolling than is necessary.

I am guessing this is a result of this bug fix, but for me it, was never broken. Lyrics were single spaced before and now they are double spaced.
Comment 6 Sue Chastain 2008-11-22 07:45:16 UTC
Created attachment 4316 [details]
sample file with lyrics that show double-spaced
Comment 7 Michael Herger 2008-11-24 03:16:15 UTC
change 24036 - fix Windows style line breaks on Controller

MeSue - please give it another try. Thanks!
Comment 8 Sue Chastain 2008-11-26 09:22:52 UTC
Thanks. My lyrics are back to normal spacing.
Comment 9 James Richardson 2008-12-18 16:10:18 UTC
Verified fixed in

SqueezeCenter 7.3.1 r24367
Controller 7.3 r3476
SqueezePlay 7.3 r3550M
Receiver r56
SB2/3 r121
Transporter r71
Boom r41
Comment 10 James Richardson 2008-12-22 11:36:44 UTC
This bug has been fixed in the 7.3.1 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 11 Chris Owens 2009-07-31 10:32:07 UTC
Reduce number of active targets for SC