Bug 9971 - some icons rendering incorrectly in choose player
: some icons rendering incorrectly in choose player
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: SB Server
: unspecified
: PC Other
: -- normal (vote)
: 7.3
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-12 10:42 UTC by Ben Klaas
Modified: 2009-09-08 09:30 UTC (History)
5 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2008-11-12 10:42:51 UTC
SB2s show up with an SB3 icon
SB3s show up with and SD logo
Controllers are not yet identified as such
Comment 1 Michael Herger 2008-11-12 21:37:08 UTC
Ben - I've recently changed a bit of the model code. CLI should now return squeezebox2 or squeezebox3 as the model (see change 23789). Maybe this broke your player icons.
Comment 2 Michael Herger 2008-11-12 21:40:08 UTC
some more information: calling $client->model() will behave as before, returning squeezebox2 (the "technical" model, if you want) for compatibility reasons. $client->model(1) will tell it to return the real model (sb2 or sb3) based on the MAC address. The code previously was in some Slim::Button code. I decided to move it to a more central place. CLI uses model(1) to return the right model. But this change might have broken some CLI applications which assume sb2 == sb3.
Comment 3 Michael Herger 2008-11-13 00:52:18 UTC
The following patch plus renaming squeezebox2.png to squeezebox3.png should do (can't test, as SP doesn't compile any more on my machine :-()

Index: /Users/mh/Documents/workspace/sp73/squeezeplay/share/applets/SelectPlayer/SelectPlayerApplet.lua
===================================================================
--- /Users/mh/Documents/workspace/sp73/squeezeplay/share/applets/SelectPlayer/SelectPlayerApplet.lua	(revision 3353)
+++ /Users/mh/Documents/workspace/sp73/squeezeplay/share/applets/SelectPlayer/SelectPlayerApplet.lua	(working copy)
@@ -176,6 +176,7 @@
 		softsqueeze = true,
 		transporter = true,
 		squeezebox2 = true,
+		squeezebox3 = true,
 		squeezebox  = true,
 		slimp3      = true,
 		receiver    = true,
@@ -189,6 +190,10 @@
 		-- use a generic style when model lists as not valid
 		playerModel = 'softsqueeze'
 	end
+	
+	if playerModel == 'squeezebox2' then
+		playerModel = 'squeezebox'
+	end
 
 	-- if waiting for a SN pin modify name
 	if player:getPin() then
Comment 4 Michael Herger 2008-11-13 01:18:29 UTC
change 3354

fix player selection skin for SB2 vs. SB3
- SC 7.3 returns squeezebox3 for a SB3 -> create new skin style for this player
- rename squeezebox2.png to squeezebox3.png
- change squeezebox2 style to use squeezebox.png instead

-> please note that this change won't fix the wrong icons on SC 7.2, as it returns squeezebox2 for SB3 too. In this case SB2 and SB3 will get the SB icon
Comment 5 James Richardson 2008-12-15 12:09:33 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.