Bug 997 – $ds->objectForUrl(Slim::Player::Playlist::song($client))->title() returns stream name instead of songtitle

Bug 997 - $ds->objectForUrl(Slim::Player::Playlist::song($client))->title() returns stream name instead of songtitle

Summary:

$ds->objectForUrl(Slim::Player::Playlist::song($client))->title() returns str...

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Database
Version:	6.0.0
Platform:	PC All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-03-09 11:16 UTC by Michael Herger
Modified:	2008-09-15 14:37 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Herger 2005-03-09 11:16:04 UTC

$ds->objectForUrl(Slim::Player::Playlist::song($client))->title() 

used to return the song title, with online streams often stuff like "This is my song - My Supergroup". When I 
tested my biography plugin today it returned the streams name instead, eg. "(#1 - 1598/19151) Radio 
Paradise - eclectic intelligent rock - music info & listener community at radioparadise.com"

The instruction above comes from Kevin and Dan wrote the similar version in my plugin - can't be my 
fault ;-)

Comment 1 KDF 2005-03-09 11:23:26 UTC

this also seems to affect status_header and now playing information when playing
streams.

Comment 2 Dan Sully 2005-03-10 00:48:21 UTC

Michael - a last minute change myself and Vidur put in - call:

Slim::Music::Info::getCurrentTitle( Slim::Player::Playlist::song($client) );

instead.

Comment 3 KDF 2005-03-10 01:30:00 UTC

actually, i think that should be:

Slim::Music::Info::getCurrentTitle($client, Slim::Player::Playlist::song($client) );
or 
Slim::Music::Info::getCurrentTitle( $client, $track->url()) );

you'll need to pass the client object in the case of your biography plugin. but
otherwise, this seems to work

Comment 4 Michael Herger 2005-03-10 01:41:23 UTC

I'm currently using it without the client object and it seems to be working:

$url = Slim::Player::Playlist::song($client)
[..]

$params->{'artist'} = Slim::Music::Info::getCurrentTitle('', $url);

Is this plain wrong?

Comment 5 Dan Sully 2005-03-10 01:42:49 UTC

That looks correct.

Comment 6 KDF 2005-03-10 01:57:55 UTC

looks good to me.  marking fixed :)

Comment 7 Chris Owens 2006-06-16 14:41:03 UTC

There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.