Bug 9936 – MUSIC string used instead of PLUGIN_RADIOTIME_MUSIC

Bug 9936 - MUSIC string used instead of PLUGIN_RADIOTIME_MUSIC

Summary:

MUSIC string used instead of PLUGIN_RADIOTIME_MUSIC

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Player UI
Version:	7.3.0
Platform:	PC Other

Importance:	P1 critical (vote)
Target Milestone:	7.x
Assigned To:	Andy Grundman

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-11-08 10:25 UTC by Andy Grundman
Modified:	2009-09-08 09:23 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andy Grundman 2008-11-08 10:25:49 UTC

This is a weird one.  Navigate into Internet Radio, the 3rd item is "Music Folder".

It seems that the button code is looking up both the correct PLUGIN_RADIOTIME_MUSIC string and then looking up the MUSIC string which overwrites the value.

Comment 1 Adrian Smith 2008-11-08 11:14:59 UTC

Its because stringExterRef is set in the mode params before calling INPUT.List

This means Input.List looks the line as a string.  I am not sure why S:B:Home.pm uses has stringExterRef => 1, you could try it without?  If there are side effects could we put a space on the end of the string so it does not match a string token?

Lots of legacy code here which hopefully dean understands...

Comment 2 Adrian Smith 2008-11-08 13:19:52 UTC

Can't see a downside to this:

--- Slim/Buttons/Home.pm        (revision 23858)
+++ Slim/Buttons/Home.pm        (working copy)
@@ -112,7 +112,6 @@
                },
 
                'externRefArgs' => 'CV',
-               'stringExternRef' => 1,
                'header' => undef,
                'headerAddCount' => 1,
                'callback' => \&homeExitHandler,

As the externRef is always converting tokens to strings, so at present it is saying a double string lookup should be done - don't see any reason for that?

Comment 3 Andy Grundman 2008-11-08 18:05:00 UTC

Thanks, fixed in change 23863.

Hopefully does not cause any regressions.

Comment 4 Ross Levine 2008-12-11 16:42:38 UTC

Verified in 7.3 - 24282.

Comment 5 James Richardson 2008-12-15 12:37:10 UTC

This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Comment 6 Chris Owens 2009-07-31 10:31:41 UTC

Reduce number of active targets for SC