Bug 9925 - Support Now Playing Screensaver buttons (currently SS disappears)
: Support Now Playing Screensaver buttons (currently SS disappears)
Status: CLOSED FIXED
Product: SB Desktop
Classification: Unclassified
Component: UI
: unspecified
: All Other
: -- normal (vote)
: 7.3
Assigned To: Richard Titmuss
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-07 08:48 UTC by Wadzinski Tom
Modified: 2009-09-08 09:21 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wadzinski Tom 2008-11-07 08:48:35 UTC
Currently any mouse action ends the screensaver.

Ben and I have experimented with adding listening for mouse events in NowPlaying and consuming them, with the idea that the Button widget listeners would still pick up the mouse_down event.

In this design, the only mouse way to end the now playing screensaver would be to click on the top back button. Clicks to the player controls would not return, since that would be jarring)

This might create odd behavior if the user was already on the non-SS now playing window, since clicking back takes you to a screen that is identical to the screen you are on, making it appear that the click didn't work. This could be dealt with be never going to the Now Playing SS if you already are on the NP window).

In pursuing this, we found that the NP Applet Window listener consumed the mouse event before the button listener could get at it. We found this behavior odd (expected the Button to be first in the listening chain). To workaround, we tried not consuming MOUSE_PRESS. This worked and the button listener gets called, but the SS was still going away (even though the button callback returned EVENT_CONSUME)
Comment 1 Ben Klaas 2008-11-07 08:58:30 UTC
fwiw, the extreme digest of the bug:

it appears that putting an EVENT_CONSUME return value in Button() widgets doesn't result in the event being consumed
Comment 2 Ben Klaas 2008-11-10 12:22:22 UTC
Richard- we forgot to talk about this one when we were on the phone this morning.

assigning to you for comment. 

(IMO, this probably could be re-targetted for 7.3.1)
Comment 3 Richard Titmuss 2008-11-18 02:03:51 UTC
Fix for mouse support in r3395. Still need to figure out how it so that the fwd/rew/etc key press does not close the screensaver.

Comment 4 Richard Titmuss 2008-11-18 03:59:57 UTC
Fixed in r3396. Ben/Tom can you please review.
Comment 5 James Richardson 2008-12-15 12:09:21 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.