Bugzilla – Bug 991
Does not appear to ignore songs disabled in iTunes
Last modified: 2009-09-08 09:15:13 UTC
Just loaded 6.0b1 and have found that songs that have been unchecked in iTunes get picked up by the server. They don't play and the server steps onto the next song but it would be better if these songs did not appear in the list.
I'll take a crack at this.
have you tried the settings in server settings->itunes? there is an option to show or not show tunes marked as 'disabled'
I've used the options within the slimserver to ignore items unchecked in iTunes. However, saying this I see to get the same issue with the previous version of slimserver so I'm wondering if the problems with my system?
I have tested the option, it does seem to work. However, there are a couple of stumbling blocks. Itunes import plugin is an importer, not a database. So, if you have your music folder set, you will have a database of merged data. Also, if you have imported with the songs enabled, or with the setting to ignore unchecked tunes, then they will have been previously imported into the slimserver database. Only if the songs are removed will the database drop the songs. Precise delete control is relatively new, so it may be possible to delete songs that are marked as disabled. To confirm that the setting at least works, set it to ignore unchecked tracks, set your music folder setting to nothing, erase the slimserversql.db file and import your itunes data again.
How about if songs are unchecked in the itunes file we remove them from the db?
well, if they are unchecked in iTunes, but they are imported from Musicmagic or Folder scan which takes precedence? my guess is that we should only do this if importer count is 1 and itunes is used (therefore is the only one in use)
Created attachment 327 [details] delete disabled tracks from db, unconditionally this initial patch deletes any tracks that are marked as disabled. if they dont exist in db, they are simply ignored. if they are brough in by other importers, it is deleted but would be restored when the other importers do their scan. I can make it conditional for when itunes is the only importer, but that will be up to Dean as to which is the right thing to do.
Dean, can you comment on this?
keith, what behaviour would be your choice? Maybe an itunes pref to choose to override or only remove if itunes is the only datasource? if so, then its a matter of wording
hi, I have serveral ideas for a solution on this. I just need a design call, whether itunes overrides all importers, deleting disabled tracks on scan. Or, delete only when itunes is the only importer in use. I am leaning more toward having itunes delete regardless, since we have the pref to ignore. if a user chooses to enable itunes, with that setting on, then I think it makes the most sense to take that as an overall ruling.
dan, I'm guessing this now becomes your call. This routine works for me, ans we can always add a conditional pref in whatever flavour you want.
I've submitted this fix as subversion change 2700.