Bugzilla – Bug 985
now playing display web settings don't match remote settings
Last modified: 2008-08-18 10:53:01 UTC
Using the remote, pressing NOW PLAYING, the display will toggle through various displays and visualisers. Using the web setting seem to leave the visualiser as is, only changing the now playing information.
sending a patch for this in a moment, creates player method for listing displaymodes. Squeezebox uses what is there now, SB2 gets a new set.
Created attachment 350 [details] new player method to create playingDisplayMode list This moves the playingDisplayMode options to a new player method. This way we can create a matched set by player type. You may want to change the strings as you see fit. I can commit tonight if this is acceptable or you can go ahead if you want it in sooner.
Looks good. Commit tonight. Thanks! A different, but related, bug is that we're ignoring the showbufferfullness pref for SB2. Seems like we're always reporting the wrong number of modes. If you're able, care to fix that as well with this checkin?
we are? where are you seeing this? The web UI seems to have the right contents.
oh, I think I see it. you are using @showBar for the mode count, then adding. It seems that showBar already includes bufferfullness, so adding 1 isnt right. I should be able to fix this, and will. Is this what is causing 1141?
I bet it is what's causing the crash.
Squeezebox2.pm, line 137 shoudl read: $count -= Slim::Utils::Prefs::clientGet($client,'showbufferfullness') ? 0 : 1; this is the quick fix. I've got a better one in mins that will use the new method and have that method include showbufferfullness or not, as set in the pref.
Created attachment 352 [details] dynamic inclusion of showfullness This should now clear up bug1141 as well. Also cleans up the args for setup. Use the new method to dynamically include the bufferfullness if set, and use this same method to set the mode count (allows for future addins)
committed r2640