Bug 9834 - Player Info displays wireless signal % for wired players
: Player Info displays wireless signal % for wired players
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.3.0
: PC Other
: P3 normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-28 09:09 UTC by Mark Miksis
Modified: 2009-07-31 10:31 UTC (History)
0 users

See Also:
Category: ---


Attachments
Only show wireless strength for wireless players (1.00 KB, patch)
2008-10-28 20:29 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Miksis 2008-10-28 09:09:01 UTC
Player information displays "Wireless Signal Strength: %" for wired players.  This bug affects all UIs.
Comment 1 Michael Herger 2008-10-28 15:32:56 UTC
you mean it does only display title and %, but no actual value?
Comment 2 KDF 2008-10-28 16:52:35 UTC
That's what it sounds like to me.  In the code, there is nothing that check's for a valid signal strength before including the wireless signal strength details in _getPlayerInfo.

There is a check on line 179 of SystemInfo (next unless defined $value) that would have gotten rid of the wireless value for wired players ($client->signalstrength is undef when wired), but with '%' added, this now evaluates to true.

Best way may be to have the signalstrength accessor return with '%' already concatenated when needed.

eg...
Squeezebox.pm, line 218:
sub signalStrength {
	my $sig = Slim::Networking::Slimproto::signalStrength(@_);
	return $sig ? $sig.'%' : undef;
}

Comment 3 Mark Miksis 2008-10-28 20:16:02 UTC
(In reply to comment #1)
> you mean it does only display title and %, but no actual value?
> 

Yes.
Comment 4 KDF 2008-10-28 20:29:45 UTC
Created attachment 4180 [details]
Only show wireless strength for wireless players

This moves the adding of '%' to the $client->signalStrength method.

I've checked the player ui, web ui and also squeezeplay r3220 and it looks more sensible now :)
Comment 5 Michael Herger 2008-10-31 00:54:37 UTC
change 23749 - hide signal strength when player is plugged in to ethernet

Kevin - I did not add the percent sign in the signalStrength() method as someone (plugin, CLI) might expect a numerical value.
Comment 6 James Richardson 2008-12-15 12:08:55 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 7 Chris Owens 2009-07-31 10:31:19 UTC
Reduce number of active targets for SC