Sorry if this sounds silly, but what should MACADDY button favorites.hold do? I presume add the current playing item to favorites? I just tried it with 7.0 and it didn't add any favorite. I'd like to validate this bug, care to help me? :-)

Yes, it is supposed to store the currently playing item to the favorites list.  It's interesting that it isn't working for you with 7.0 though because we've been using it in our Crestron module for awhile now and it was working until the last couple revisions.

Just tried it again this time with a track in my library rather than Internet radio stream, still no favorite is added. Would you mind trying with your PC? I'm using your command exactly, except of course changing to the MAC of my player. Sorry to be so daft but I've never had great luck with CLI, I appreciate you helping me. 

Hi Ross,
I just downgraded my system here at the office and unfortunately I can't get the Duet do downgrade it's firmware because it asks me to press and hold the brightness button on the squeezebox remote which the duet doesn't have (perhaps I should file another bug report for that :) )

I'm not sure what else to say other than it used to work and now it doesn't.  Would it be possible to have this bug moved over to someone more familiar with the CLI?

Thanks,
-Steve

Michael, can you offer me some help to validate this bug? The command I'm trying:

00:04:20:06:2f:a4 button favorites.hold<LF>

CLI response:

00%3A04%3A20%22%08%3A06%3A2f%3Aa4 button favorites.hold%3CLF%3E

The player is an SB3, playing a local track or Internet radio stream, no favorite is saved with 7.0 or 7.3, at least for me. 

> 00:04:20:06:2f:a4 button favorites.hold<LF>

Don't type the <LF> in the command. It's meant to symbolize the return key you hit.

I dont send it with <LF>.  I send it with the hex value 0A.  This has always worked in the past so I just need somebody to find out why it is not working anymore.  I is still in the CLI so I assume it should still be a valid command 

Thanks Michael, I tried without <LF>, still does nothing. Michael if you have any other suggestions let me know here I would be happy to investigate. 

00:04:20:06:2f:a4 button favorites.hold
00%3A04%3A20%3A06%3A2f%3Aa4 button favorites.hold

Steve, you may want to try asking in the forums. 

Hi Ross,
I already posted this in the forums but got no response.  I am a little confused about why you need to see it work to verify it is in fact a bug though.  I can yell you without a doubt that it did work because I tested it with the module we wrote.  The command is documented in the help file so it 'should' work, shouldn't it?

Phil Brady (emcc) mentioned encountering problems with other "button" commands too. 

"Also we're having some problems with Pause on 7.2.1, we command a pause using the CLI command "<player> button pause" but its unstable, half the time it doesn't work, also I've noticed it doesn't work when the softsqueeze player's display has dimmed. Is this a known issue?
 
the other thing I've noticed is "<player> button play" doesn't work when the player has just been powered on. It starts working again after a "<player> button stop"


Ross - could you please check whether we have a generic problem with the button command (not only favorites)? Thanks!

Thanks Michael for your help with CLI. I'm able to get most CLI commands to work, however the button command I am having no luck with. Not only does favorites.hold not work, but I can't get any of the button commands to work. I've also tried against 7.0, and I'm unable to get any of the button commands to work via CLI with 7.0 as well. 

We should try to fix this for 7.3.1. It's a documented feature and I've had complaints about it by other developers too.

Thanks Michael, I'd very much appreciate that.  Ive been getting some emails from end-users of our integration module asking why these features aren't working.  I'll let them know that you are aware of the issue and are working on it. 

What shall I say... it's working perfectly fine for me: started playback, paused, defined favorites all using the button commands. This is with the latest 7.3 trunk rev. 23907.

But there's one hugely important caveat: the button command will work on players with a display only. As it emulates the IR remote button presses, it won't work on any player which doesn't have an IR remote, eg. Receiver. Therefore I'd strongly recommend not to use the button command, but independant commands such as "favorites add ..." etc.

Adrian - is the button command supposed to work on a mode-less player like the Receiver?

(In reply to comment #14)
> What shall I say... it's working perfectly fine for me: started playback,
> paused, defined favorites all using the button commands. This is with the
> latest 7.3 trunk rev. 23907.
> 
> But there's one hugely important caveat: the button command will work on
> players with a display only. As it emulates the IR remote button presses, it
> won't work on any player which doesn't have an IR remote, eg. Receiver.
> Therefore I'd strongly recommend not to use the button command, but independant
> commands such as "favorites add ..." etc.
> 

Thanks for the reply Michael.  I have been doing a lot of my testing with the Duet so that could explain why I haven't been able to get it to work.  I could swear the button command for "add favorite" wasn't working when I tested it with the Sqeezebox classic too but I will double check that.  I'll update our help file to let people know that the button commands will not work with those players as well.  

Michael - I can't see how it can work at present on a mode less player.

We could force Receiver to always be in a specific mode e.g. home, but this would tend to question the approach of removing the button modules if players don't have IR.  So I would suggest not using it on a IR less player.

In general from the cli we really want users to call the command which carries out the function they want to perform, not a button command which then does this.  If there are key commands which can only be done via button cli commands then we need to look at exposing them properly...

Thanks Adrian. That's what I thought.

Steve - I'll close this bug as "wontfix". Pleaes re-open if you see issues running the button commands on classic players with display. Thanks for your understanding.

Reduce number of active targets for SC