Bug 9802 – Enable Replay Gain for Squeezeslave players

Bug 9802 - Enable Replay Gain for Squeezeslave players

Summary:

Enable Replay Gain for Squeezeslave players

Status:	RESOLVED INVALID

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Softsqueeze
Version:	unspecified
Platform:	PC Windows Server 2003

Importance:	-- normal (vote)
Target Milestone:	Future
Assigned To:	Richard Titmuss

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-10-24 10:28 UTC by Jim McAtee
Modified:	2009-10-17 00:16 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jim McAtee 2008-10-24 10:28:56 UTC

It's not possible under player settings > audio to configure Replay Gain with Squeezeslave clients.  (Does SC know when it's connected to a Squeezeslave client, distinct from a Softsqueeze client?)  According to the Squeezeslave authors, RG support is implemented in Squeezeslave, so I'm guessing that this probably just needs to be recognized at the server and the settings section enabled.

Comment 1 James Richardson 2008-10-24 11:19:33 UTC

Ben: would this be a SP thing as well?

Comment 2 Ben Klaas 2008-10-24 11:24:59 UTC

not related to Squeezeplay

Comment 3 Jim McAtee 2008-10-24 12:46:33 UTC

Taking a quick look at the code, it seems the reason is that by default SC sets a player's canDoReplayGain property to false, so an unrecognized player type such as Squeezeslave will end up this setting.

Would it be safe to change the default to true and override it on players that can't do RG?  That would just be the SLIMP3 and Squeezebox, correct?

Comment 4 James Richardson 2008-10-30 11:13:49 UTC

Richard: your thought on this issue?

Comment 5 Jim McAtee 2009-10-17 00:16:43 UTC

Closing... dead application.