Bug 9780 - PNG images being generated for Now Playing
: PNG images being generated for Now Playing
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Artwork
: 7.3.0
: PC Windows Server 2003
: -- normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-21 22:36 UTC by Jim McAtee
Modified: 2009-07-31 10:31 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2008-10-21 22:36:09 UTC
I thought that from the discussion in bug 6471 PNG images were no longer going to be generated if the original image file format was JPEG.  Perhaps it was just overlooked in Now Playing.  This is also the case when using SqueezeJS.UI.Coverart.  As an example, requesting a 512x512 image generated from a 26kB 300x300 JPG original resulted in a PNG that is 307 kB in size.
Comment 1 James Richardson 2008-10-24 23:17:29 UTC
Michael is this one for you or Andy?
Comment 2 Michael Herger 2008-10-27 05:03:35 UTC
change 23695 - keep file type as jpeg if the original aspect ration of the image is to be returned (_o_ parameter). 

Jim - .jpg will still be returned as .png if the file format needs padding. That's the case when the aspect ratio isn't exactly 1:1 and aspect ratio is not to be kept. The 1:1 case was already in place, but not the _o_ parameter. Can you make sure your artwork either is 1:1 or you're using something like cover_1000x1000_o as the file name?
Comment 3 Jim McAtee 2008-10-28 14:58:33 UTC
Most of my images are square, but a few are not. In the example I gave above, the original image was square.

What's the request syntax for "resize to fit largest dimension to xx pixels, keeping original aspect ratio and file format"?

I saw your change 23698 to correct the pre-caching.  Since you don't need square images, shouldn't you also being using the same approach of requesting (and pre-caching) images fitted to just the max dimension, rather than square images?  It's unnecessary in the web interface, and from the discussion in bug 6471, alpha transparency is no longer needed on the Controller.
Comment 4 Michael Herger 2008-10-29 04:30:09 UTC
> What's the request syntax for "resize to fit largest dimension to xx pixels,
> keeping original aspect ratio and file format"?

that's the _o parameter without extension
Comment 5 James Richardson 2008-12-15 12:08:29 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 6 Chris Owens 2009-07-31 10:31:04 UTC
Reduce number of active targets for SC