Bug 9760 - external mysqld results in a lot of "uninitialized value" warnings on startup
: external mysqld results in a lot of "uninitialized value" warnings on startup
Status: RESOLVED WONTFIX
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 7.4.1
: PC Linux (other)
: P5 minor with 1 vote (vote)
: 7.4.x
Assigned To: Squeezebox QA Team email alias
http://forums.slimdevices.com/showthr...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-19 11:56 UTC by Markus Schiegl
Modified: 2011-03-16 04:39 UTC (History)
0 users

See Also:
Category: Bug


Attachments
patch against 7.3trunk (350 bytes, patch)
2008-10-19 11:56 UTC, Markus Schiegl
Details | Diff
patch against 7.4trunk (463 bytes, patch)
2009-03-08 01:31 UTC, Markus Schiegl
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Schiegl 2008-10-19 11:56:59 UTC
Created attachment 4154 [details]
patch against 7.3trunk

If you use the bundled mysqld part of the initialization in S::U::MySQLHelper.pm is a call to $class->dbh which itself silences all warnings ($^W = 0).

Using an external mysqld leaves MySQLHelper.pm to early, so a lot of warnings (most of them "uninitialized value") will be printed to the server.log, e.g.

[08-09-24 07:39:23.4147] Slim::Utils::Misc::msg (1125) Warning: [07:39:23.4142] Use of uninitialized value in concatenation (.) or string at /opt/SqueezeCenter_svn/7.3/trunk/server/Plugins/IRBlaster/Plugin.pm line 955.
[08-09-24 07:39:24.6706] Slim::Utils::Misc::msg (1125) Warning: [07:39:24.6701] Use of uninitialized value in string eq at /opt/SqueezeCenter_svn/7.3/trunk/server/Plugins/IRBlaster/Plugin.pm line 1261.
[08-09-24 07:39:25.3761] Slim::Utils::Misc::msg (1125) Warning: [07:39:25.3756] Use of uninitialized value in hash element at /opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Control/Request.pm line 996.
...
[08-09-24 07:39:44.6845] Slim::Utils::Misc::msg (1125) Warning: [07:39:44.6843] Use of uninitialized value in string ne at /opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Control/Request.pm line 1004.
[08-09-24 07:39:44.6851] Slim::Utils::Misc::msg (1125) Warning: [07:39:44.6849] Use of uninitialized value in concatenation (.) or string at /opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Control/Commands.pm line 943.
[08-09-24 07:39:44.6855] Slim::Utils::Misc::msg (1125) Warning: [07:39:44.6852] Use of uninitialized value in concatenation (.) or string at /opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Control/Commands.pm line 956.
[08-09-24 07:39:44.7975] Slim::Utils::Misc::msg (1125) Warning: [07:39:44.7966] Use of uninitialized value in multiplication (*) at /opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Player/Squeezebox2.pm line 230.
[08-09-24 07:39:44.8123] Slim::Utils::Misc::msg (1125) Warning: [07:39:44.8119] Use of uninitialized value in multiplication (*) at /opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Player/Squeezebox2.pm line 230.
[08-09-24 07:39:44.8129] Slim::Utils::Misc::msg (1125) Warning: [07:39:44.8126] Use of uninitialized value in multiplication (*) at /opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Player/Squeezebox2.pm line 230.
[08-09-24 07:39:45.3693] Slim::Utils::Misc::msg (1125) Warning: [07:39:45.3689] Use of uninitialized value in sysread at /opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Player/Protocols/File.pm line 208.
...
[08-09-24 07:40:03.8411] Slim::Utils::Misc::msg (1125) Warning: [07:40:03.8405] Use of uninitialized value in concatenation (.) or string at /opt/SqueezeCenter_svn/7.3/trunk/server/Plugins/IRBlaster/Plugin.pm line 955.
[08-09-24 07:40:03.8423] Slim::Utils::Misc::msg (1125) Warning: [07:40:03.8421] Use of uninitialized value in concatenation (.) or string at /opt/SqueezeCenter_svn/7.3/trunk/server/Plugins/IRBlaster/Plugin.pm line 955.
[08-09-24 07:40:03.8725] Slim::Utils::Misc::msg (1125) Warning: [07:40:03.8720] Use of uninitialized value in hash element at /opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Control/Request.pm line 996.
[08-09-24 07:40:03.8737] Slim::Utils::Misc::msg (1125) Warning: [07:40:03.8734] Use of uninitialized value in hash element at /opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Control/Request.pm line 996.
[08-09-24 07:40:03.8818] Slim::Utils::Misc::msg (1125) Warning: [07:40:03.8815] Use of uninitialized value in multiplication (*) at /opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Player/Squeezebox2.pm line 230.
[08-09-24 07:40:03.8822] Slim::Utils::Misc::msg (1125) Warning: [07:40:03.8820] Use of uninitialized value in multiplication (*) at /opt/SqueezeCenter_svn/7.3/trunk/server/Slim/Player/Squeezebox2.pm line 230.
...

The attached patch disables warnings in case of using an external db, too.

kind regards,
Markus
Comment 1 James Richardson 2008-10-30 13:36:34 UTC
Ross, please check out the patch to see if it can be intergrated
Comment 2 Markus Schiegl 2008-11-16 03:17:14 UTC
I know you guys have a lot to do before releasing 7.3 and i know this bug is not critical at all. But IHMO it's a really low hanging fruit (no change in functionality, duplicates the behaviour for internal+external mysql usage) and would help those who regularly analyze and collect logfiles. Please consider. I'll accept your decision and won't bother any longer :-)

Thanks,
Markus
Comment 3 Markus Schiegl 2009-03-08 01:31:51 UTC
Created attachment 4900 [details]
patch against 7.4trunk

for the sake of completeness: the same patch for 7.4
Comment 4 Ross Levine 2009-06-23 11:46:17 UTC
Markus is this a problem with any other distro's? I don't know when I'll have time to setup a Gentoo install. :-(
Comment 5 Markus Schiegl 2009-06-23 13:07:10 UTC
(In reply to comment #4)
> Markus is this a problem with any other distro's? I don't know when I'll have
> time to setup a Gentoo install. :-(

yes it is. AFAIK it applies to Windows, too (see thread). The only requirement is the usage of an external mysqld.
Comment 6 Markus Schiegl 2009-10-23 09:25:49 UTC
A reason for "RESOLVED WONTFIX" would have been nice...
Comment 7 James Richardson 2009-10-23 09:30:46 UTC
Markus: you are correct, and I apologize for that.  I hit the comment button before typing in text.

Currently, we do not have enough resources to properly address this issue.  Since we ship our own MySQL, which works it was decided to not address this issue.  It will have to be left up to the individual developers that wish to use an external MySQL to address the issue on a case by case basis.
Comment 8 Markus Schiegl 2009-10-23 09:36:26 UTC
James: Thanks for explaining! understood and accepted.