Bug 9752 - fade_volume doesn't always call callbacks at end of fade
: fade_volume doesn't always call callbacks at end of fade
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Misc
: 7.2
: All All
: P3 normal (vote)
: Future
Assigned To: Alan Young
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-17 14:51 UTC by Max Spicer
Modified: 2009-06-09 01:48 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max Spicer 2008-10-17 14:51:10 UTC
S::P::Player::fade_volume doesn't call its registered callback if it stops the fade because it detects a manual volume whilst it is doing a fade.  S::C::Commands::mixerCommand calls fade_volume but asks it to do a callback to _mixer_mute when it's done.  If volume is altered during this fade period, the callback doesn't happen and so the mute isn't completed and the player carries on playing, despite reporting itself as paused.

This is unlikely to be triggered by the user altering the volume as fades happen quickly.  However, it can cause some weird interaction issues when things do stuff programatically during the fade period.
Comment 1 Alan Young 2009-06-09 01:48:50 UTC
Change 26957.