Bug 9737 - Add Boom-Like 'Snooze' Clock Display to SB
: Add Boom-Like 'Snooze' Clock Display to SB
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 7.2
: All All
: -- enhancement (vote)
: 7.x
Assigned To: Andy Grundman
https://bugs-archive.lyrion.org/show_bug....
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-16 11:20 UTC by slav
Modified: 2009-09-08 09:12 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
change to Default.map to user sleep button as snooze (11.29 KB, patch)
2008-10-16 11:21 UTC, slav
Details | Diff
changes to Date/Time Plugin.pm (6.95 KB, patch)
2008-10-16 11:22 UTC, slav
Details | Diff
Sleep Button Snooze - Patch (1.41 KB, patch)
2008-11-12 14:15 UTC, slav
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description slav 2008-10-16 11:20:23 UTC
enhancement request: taken from resolved bug 9476 to show the clock display when SB is off by pressing the Sleep button - similar to the Boom when pressing the Snooze button.

Proposed patch below & attached files:

Remove the sleep.* line and put in the same as the snooze button in the
default.map file:

sleep.single                    = snooze
sleep.hold                      = dead


Other enhancements:

1. have the time show up even if the display is not 0(dark). I often have my
bedroom SB set to dispay 1 when off, so I would like to be able to press sleep
and have it brighten up to see better. (this could also be a user option).

2. have the time show up at max brightnes (not 'powerOn' brightness). When
showing time w/ the sleep/snooze button, you can assume that a person would
like to see it bright. Again, my bedroom SB 'powerOn' brightness is often 1, so
pressing the sleep/snooze button and having its brightness 1 isn't all that
useful. (this could also be a user option).

Propsed patch in attached file.

I'm not a programmer, so I'm sure the syntax/coding style isn't quite right, but it's working for me, thanks!
Comment 1 slav 2008-10-16 11:21:58 UTC
Created attachment 4143 [details]
 change to Default.map to user sleep button as snooze
Comment 2 slav 2008-10-16 11:22:22 UTC
Created attachment 4144 [details]
 changes to Date/Time Plugin.pm
Comment 3 James Richardson 2008-10-16 11:26:26 UTC
Slav: thanks for the patch.

Andy: can you take a look at the patch and implement for 7.3
Comment 4 KDF 2008-10-16 12:43:34 UTC
this effectively turns the 'sleep' remote button into a 'snooze' button.  cc'ing Dean as I believe his intent was to keep these as different button behaviours.
Comment 5 James Richardson 2008-11-03 09:28:11 UTC
Ping Dean.
Comment 6 Blackketter Dean 2008-11-03 15:05:58 UTC
As long as the old sleep behavior (i.e. when playing, press sleep button to start sleep timer) still works, this seems like a win.

Comment 7 slav 2008-11-03 15:49:55 UTC
-this only affects the sleep button when the player is off
-when power is on, the sleep button functions as normal (starts sleep timer)
Comment 8 Andy Grundman 2008-11-09 13:15:31 UTC
Thanks, but please re-attach patches against 7.3, not full files.
Comment 9 slav 2008-11-09 20:15:24 UTC
ok - I'll get this going for 7.3
question: how do I attach just a patch & not the full file??
thx.
Comment 10 Andy Grundman 2008-11-10 08:42:19 UTC
The easiest way is to checkout the source using Subversion, edit in your changes, and run svn diff on the files.

Or you can make a copy of the original file, edit your changes, and run:

diff -u old_file new_file
Comment 11 slav 2008-11-12 11:19:32 UTC
thanks Andy
However I'm having some problems w/ this (I've never done this before)
I installed subversion, and tried a checkout (based on some syntax I found in the forums) and this is what I get:
C:\temp>svn co http://svn.slimdevices.com/7.3/trunk/server/IR/Default.map
svn: XML data was not well-formed

When I try w/ /repos/ in the URL I get:
C:\temp>svn co http://svn.slimdevices.com/repos/7.3/trunk/server/IR/Default.map
svn: Server sent unexpected return value (403 Forbidden) in response to OPTIONS
request for 'http://svn.slimdevices.com/repos/7.3/trunk/server/IR/Default.map'

Am I using the wrong syntax? Wrong URL??
thx.
Comment 13 slav 2008-11-12 14:15:16 UTC
Created attachment 4239 [details]
Sleep Button Snooze - Patch
Comment 14 slav 2008-11-12 14:31:29 UTC
-uploaded patch
-tested OK w/ 7.3
-hopefully the way I created the patch was right (it looks OK viewing above): thanks Andy for helping w/ the patch creation/subversion process
Comment 15 Andy Grundman 2009-01-05 11:58:58 UTC
Added in change 24511.
Comment 16 Ross Levine 2009-01-16 17:44:06 UTC
Verified to be working in 7.3.3 - 24684. 
Comment 17 James Richardson 2009-01-22 09:58:12 UTC
Fixed - Closed Message (SC)

This bug has been fixed in the 7.3.3 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 18 James Richardson 2009-01-22 13:53:33 UTC
Correction: SqueezeCenter version is 7.3.2
Comment 19 Chris Owens 2009-07-31 10:30:55 UTC
Reduce number of active targets for SC