Bugzilla – Bug 9730
Choose Player for Controller needs style
Last modified: 2008-10-16 14:00:04 UTC
7.3 r3131, when the controller is connected as a player, the Controller's player item is not styled in the choose player menu. It is still selectable, however.
Created attachment 4142 [details] incorrect player icons Sometimes even a SB3/Ray comes up without an icon. Or with the incorrect icon (see screenshot - the Ben avatar is a SB3)
I'll get this fixed today...also, sorry about the not-very-professional "Ben avatar". That was a placeholder that wasn't supposed to be checked in. Also, I should note that before 7.3 there will be an entirely new set of graphics for these provided by Noah.
will the new graphics also differentiate between sb2 and sb3?
we'll have graphics for them, but the problem there (I think) is that SC will identify both models to SBC as "squeezebox2". So if we want different images for the two, SC will have to have some code changes as well to differentiate. That has some far-reaching implications, since there are probably several places in SC that say things like "if $player->model eq 'squeezebox2'"
Slim::Buttons::Information::playerModel is an existing function to differentiate SB2/3. It's used in Menu::SystemInfo. It looks like all of the SC-based cases of player->model eq 'squeezebox2' are involved in the Sync code. They can safely stay that way, as the SB2/3 are the same on that level. S::B::I::playerModel returns the usual model string if it's not detected as an SB3.
r3148 should fix the issue also added slimp3 artwork and replaced my forum avatar with the SD logo for softsqueeze players. These are all placeholders until we get artwork from Noah, just a little more professional than my geeky avatar :)
(In reply to comment #3) > will the new graphics also differentiate between sb2 and sb3? > It would also be nice to have different graphics to differentiate between SqueezePlay (desktop app) and an SBC. I'm not sure if SC currently supports this either.