Bug 9723 - Tidy up handling of contributor tags
: Tidy up handling of contributor tags
Status: NEW
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.2
: All All
: P5 enhancement (vote)
: 8.0.0
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-15 04:35 UTC by Christopher Key
Modified: 2009-11-02 02:05 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Patch to tidy up handling of contributor tags (1.75 KB, patch)
2008-10-15 04:35 UTC, Christopher Key
Details | Diff
Tidy artist roles (1.79 KB, patch)
2009-11-02 02:05 UTC, Christopher Key
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Key 2008-10-15 04:35:53 UTC
Created attachment 4135 [details]
Patch to tidy up handling of contributor tags

At present, supplementary contributor data (sortname, musicbrainzid) is only partially read.

Rather than having lots of hardcoded lists of tags, which are prone to ending up incomplete and to typos (e.g. MUSICBRAINZ_ALBUM_ARTIST_ID in Schema.pm), Slim::Schema::Contributor->contributorRoles() should be used as a basis for the taglist.

Attached is a patch which implements such functionality.  As well as Slim::Schema, some updates may be required to Formats::* for each specific file format.  The patch only deals with FLAC, as that's the only format I have readily available to test with.
Comment 1 Christopher Key 2008-10-15 04:36:52 UTC
Sorry, this bug/patch relates to 7.2
Comment 2 Chris Owens 2009-03-16 09:38:16 UTC
We are now planning to make a 7.3.3 release.  Please review your bugs (all marked open against 7.3.3) to see if they can be fixed in the next few weeks, or if they should be retargeted for 7.4 or future.

Thanks!
Comment 3 Chris Owens 2009-03-30 17:30:36 UTC
Since there's now a planned 7.3.3 release, bugs which won't make the cut-off are being moved to the next target out.  If you feel that this bug needs to be addressed more (or less) urgently than the 7.4 release, please cc chris@slimdevices.com and leave a comment in the bug to that effect so we can review it.

Thanks.
Comment 4 Chris Owens 2009-03-31 08:52:59 UTC
For some reason Bugzilla did not change the target when I did this yesterday.  Or maybe it was me.  In either case, I'm trying it again.
Comment 5 Andy Grundman 2009-07-29 14:58:48 UTC
Moving 7.4 bugs to 8.0.
Comment 6 Christopher Key 2009-11-02 02:05:47 UTC
Created attachment 6245 [details]
Tidy artist roles

Updated patch against 7.4.1