Bug 9622 - CLI "artist ?" queries needs to be silenced for internet radio streams
: CLI "artist ?" queries needs to be silenced for internet radio streams
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: CLI
: 7.2.1
: PC Windows Vista
: -- normal (vote)
: ---
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-10-01 12:45 UTC by Michael Avanessian
Modified: 2009-03-08 16:46 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Avanessian 2008-10-01 12:45:20 UTC
Some 3rd party software communicate with SqueezeCenter via CLI sending the following CLI commands repeatedly (5 seconds apart):
<playerid> artist ?

If the current playing stream is a remote stream (internet radio) then squeezecenter will fail on the artist ? command and log an error in server.log.
The CLI api does not state this command is only allowed when non remote streams are playing. In this case the artist ? query should fail silently.


Error in server.log:

[08-09-29 16:49:31.0339] Slim::Plugin::CLI::Plugin::cli_process (627) Request [artist] failed with error: Bad dispatch!
[08-09-29 16:49:36.0134] Slim::Control::Request::execute (1887) Error: While trying to run function coderef [Slim::Control::Queries::cursonginfoQuery]: [Can't call method "name" on an undefined value at /<C:\PROGRA~1\SQUEEZ~1\server\SQUEEZ~1.EXE>Slim/Control/Queries.pm line 882.
Comment 1 Adrian Smith 2008-10-01 15:08:21 UTC
Fixed in svn 23373 - please test the next nightly
Comment 2 Michael Avanessian 2009-02-27 17:03:42 UTC
Triode, you stopped the errors from happening.  Which technically "fixes" the problem.  But, I just realized that it also stopped SC from responding with the artist info via CLI during Internet music playback.  I meant in this bug report to silence the errors.. not to completely turn off a response for artist name!
Comment 3 Adrian Smith 2009-02-28 04:11:15 UTC
The fix only stopped causing an error when there is no artist stored in the database - it does not stop the artist being returned if it is in the database.

For remote streams I would not expect to see the artist in the database - can you clarify when you saw this before?
Comment 4 Michael Avanessian 2009-03-08 16:46:40 UTC
Sorry my error.  I found out that I was completely wrong with the information I provided.  Please disregard my comments.  Closing this ticket.  Reopened by error.