Bug 9605 - MIP-Mixes won't contain tracks with non-ascii characters in it's file/directoryname
: MIP-Mixes won't contain tracks with non-ascii characters in it's file/directo...
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: MusicIP
: 7.3.0
: PC Linux (other)
: P3 normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-29 11:51 UTC by Markus Schiegl
Modified: 2011-03-16 04:39 UTC (History)
0 users

See Also:
Category: ---


Attachments
2 logs (plugin.musicip=debug) + screenshot (21.13 KB, application/octet-stream)
2008-09-29 11:51 UTC, Markus Schiegl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Schiegl 2008-09-29 11:51:24 UTC
Created attachment 4079 [details]
2 logs (plugin.musicip=debug) + screenshot

As proposed in bug 5637 i'll list the last remaining problem i have with (my) MusicIP integration.

excerpt:

unfortunatey a regresssion crept in between 7.2 and 7.3 because of the switch
to LWP (in the broadest sense). Creating mixes from other songs will never contain tracks with utf8-encoded files

i think the problem is caused by calling $reponse->decoded_content (Plugin.pm,
line 796) whereas in 7.2 it used $http->content only. The following patch fixed
the problem for me.

Index: Slim/Plugin/MusicMagic/Plugin.pm
===================================================================
--- Slim/Plugin/MusicMagic/Plugin.pm    (revision 23162)
+++ Slim/Plugin/MusicMagic/Plugin.pm    (working copy)
@@ -793,7 +793,7 @@
                }
        }

-       my @songs = split(/\n/, $response->decoded_content);
+       my @songs = split(/\n/, $response->content);
        my $count = scalar @songs;

        for (my $j = 0; $j < $count; $j++) {


- system: Gentoo Linux 64bit, stable
- SqueezeCenter Version: 7.3r23183 - TRUNK @ UNKNOWN - Linux - EN - utf8
- using --charset=utf8 (which i normal don't) doesn't make any difference 

$ locale
LANG=en_US.UTF-8
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=en_US.UTF-8

Logs attached... (compressed to preserve each bit)

server-content-decode.log (default): contains the log of a 5-track mix, but
only three are displayed (screenshot-decode.png).

server-content-only.log (my patch from #48, mimics the codings + behaviour from
SC 7.2): contains the log of a 5-track mix, all files are displayed in the SC.

Using the non modified Plugin.pm the first line from
"Slim::Plugin::MusicMagic::Plugin::getMix (811) Original" looks different than
Slim::Plugin::MusicMagic::Plugin::getMix (761) Creating mix for:" Both should
look the same, don't they?

Applying the Patch at least matches both codings to be equal - not     
necessarily correct (although i hoped)

thanks!
Comment 1 Michael Herger 2008-10-01 01:23:23 UTC
Thanks for re-submitting this. I thought I had fixed it already, but probably never checked it in... testing again on Win/OSX/Linux.

BTW: please don't pack attachments. We're working on bugs all day long and it's much simpler if the browser can just display them instead of having to download, unpack, view, delete. Thanks!
Comment 2 Michael Herger 2008-10-01 03:11:24 UTC
change 23364 - there were a few more encoding related issues. Please give it a try. Should now work on all supported platforms. Thanks!
Comment 3 Markus Schiegl 2008-10-01 11:04:07 UTC
(In reply to comment #2)
> change 23364 - there were a few more encoding related issues. Please give it a
> try. Should now work on all supported platforms. Thanks!
> 

i cannot speek for all platforms, but i can confirm that the problem is now fixed on my system. thanks a lot!
Comment 4 James Richardson 2008-12-15 12:08:00 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 5 Chris Owens 2009-07-31 10:30:22 UTC
Reduce number of active targets for SC