Bugzilla – Bug 9553
Track title metadata missing when track title contains ellipsis in cue file
Last modified: 2009-07-31 10:30:11 UTC
Created attachment 4040 [details] Diag for check and test the error. I've whole album flac wit embedded quesheet. In ver. 6.5 this file was OK. In 7.1 and 7.2 some track titles seemed to be blank. In Cosi fan tutte track 9 and 14 were blank. In the attachment there are good and bad cuesheet files, and the screenshots. You can see, track 9 and 14 are missing, track 12 is always good, it also contains an Ellipsis character. The cuesheet differeces: I have replaced the ellipsis character (three dots) to three individual dots. Even in the bad format the track 9 and 14 are also played correctly. The .flac file is a small nosound file exactly in the same format then the original (which is 300 Mbyte). The missing text is present on the server and on my SB3 screen. I've tested on OpenSuse and Windows platform. Regards, Gaspar
QA
Created attachment 4299 [details] Screen grab showing incorrect metadata in SC from cue with ellipsis I find it odd that the ellipsis causes issues with the title info for track 9 and track 14 but not 12.
Changed summary. Screen shot was form Mac OS X 10.5.5 with SC Version: 7.3 - 23951 Michael, would this one be for you?
change 24329 - Encode::Detect::Detector sometimes is mislead to interpret utf8 as Big5. In this case we might want to give Encode::Guess another try This change fixes three out of four cases of the above CUE sheet. Why the fourth fails - I don't know. Looks like a very low level bug to me: a regular expression is returning true, but still the back references remain empty.
Wasn't low level at all: my debug statement lead to the faulty result. This is now working in rev. 24329.
This bug has been fixed in the 7.3.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
This bug fix breaks playing the station http://www.rthk.org.hk/live2.asx (see http://forums.slimdevices.com/showpost.php?p=375908&postcount=3 ) This plays OK before the Unicode.pm update and fails with "no items in playlist" after update has been applied.
The current patch means guess_encoding can abort under certain encodings and return incorrect result. I suggest the following pathc which puts guess_encoding in an eval. When tested with http://www.rthk.org.hk/live2.asx the log below shows that the problem with guess_encoding. The suggested patch Index: Slim/Utils/Unicode.pm =================================================================== --- Slim/Utils/Unicode.pm (revision 24460) +++ Slim/Utils/Unicode.pm (working copy) @@ -662,9 +662,13 @@ # Encode::Detect::Detector is mislead to to return Big5 with some characters # In these cases Encode::Guess does a better job... (bug 9553) if (lc($charset) eq 'big5') { - - $charset = Encode::Guess::guess_encoding($_[0])->name; - + eval { + $charset = Encode::Guess::guess_encoding($_[0])->name; + }; + + if ($@) { + Slim::Utils::Log->logger('server')->warn("Error guessing charset of a big5 string: $@"); + } } $charset =~ s/utf-8/utf8/i; When tested with the above URL - the log shows how guess_encdoing fails. [09-01-01 16:47:02.4468] Slim::Utils::Unicode::encodingFromString (669) Error guessing charset of a big5 string: [09-01-01 16:47:02.4486] Slim::Utils::Unicode::encodingFromString (669) Error guessing charset of a big5 string: Can't locate object method "name" via package "No appropriate encodings found!" (perhaps you forgot to load "No appropriate encodings found!"?) at /home/repos/slim/7.3/trunk/server/Slim/Utils/Unicode.pm line 666.
Thanks Bryan - change 24497
Created attachment 4685 [details] One 7.3.1 and two 7.3.2 nightly screenshots I've got a mail, the 7.3.1 solved the problem. If you try with the flac "Mozart - Cosi Fan Tutte (Böhm-1955) - D1.flac" there will be No album, no artist, the music can not be played. If I've uninstalled 7.3.1 then installed the 7.3.2.24695 nightly, practically the same situation occured, what I reprted originally. This time I've tested it only on Windows XP platform. There are 3 screenshots in the attachment describing the situation.
Reduce number of active targets for SC