Bug 9547 - Playlist::removeTrack() confuses Jive
: Playlist::removeTrack() confuses Jive
Status: NEW
Product: Logitech Media Server
Classification: Unclassified
Component: Plugin
: 7.2
: PC Windows XP
: -- normal (vote)
: Future
Assigned To: Eric Koldinger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-19 09:16 UTC by Eric Koldinger
Modified: 2009-01-08 09:50 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Koldinger 2008-09-19 09:16:25 UTC
Using the RemovePlayedSongs plugin (http://www.koldware.com/SlimStuff), I've discovered that execution of the Playlist::removeTrack() method seems to confuse the playlist on the SB Controller.

As soon as the track is deleted, the playlist on the controller updates itself into a state where the song list is only a list of the "busy" icons (the circle of dots with the dots rotating around).  The only way to get it back to a sane state seems to be to start a new album and force the whole list to reset.
Comment 1 Chris Owens 2008-09-22 10:59:04 UTC
Ben could you have a look at this?  Should this be targeted for 7.2.1?
Comment 2 Ben Klaas 2008-11-02 12:29:49 UTC
Is this still an issue?
Comment 3 Ben Klaas 2008-11-04 08:17:46 UTC
hi Eric, I downloaded and installed the RemovedPlayedSongs plugin. I can't seem to get it to do what it's supposed to do.

When I first tried to get to the player settings for the plugin, the web interface hangs and I see this on the console.
[10:03:46.2812] Slim::Networking::IO::Select::select (271) Error: Select task failed: Can't locate object method "extSetDefaults" via package "Plugins::ResetVolume::Plugin" (perhaps you forgot to load "Plugins::ResetVolume::Plugin"?) at /Users/bklaas/svk/slim/7.3/trunk/server/Plugins/RemovePlayedSongs/PlayerSettings.pm line 46.

I got around this by installing your ResetVolume plugin (that seems like a bug to require ResetVolume for RemovePlayedSongs?)

After I worked around that I got to the settings menu for RemovedPlayedSongs and enabled it for my player. 

However, after songs in my playlist completed they would not be removed.

I went and set plugin.RemovedPlayedSongs logging to debug. I see this on the console but nothing else...

[10:13:00.7007] Plugins::RemovePlayedSongs::Plugin::newSongCallback (80) newSongCallback: Office sbr 1 playlist

could you give me some pointers on how to make this work?

Comment 4 Eric Koldinger 2008-11-04 08:59:25 UTC
Looks like a cut and paste error.  I copied the settings code from ResetVolume, and looks like I forgot to remove that line.

Just remove the line that calls extSetDefaults().  All it would is set default preferences, and in this case, the wrong ones.

I'll fix that in the version on my site.

Interesting that nobody else has complained.

Eric
Comment 5 Eric Koldinger 2008-11-04 09:04:47 UTC
As far as making it work, you should just be able to plug it in, enable it, and it should start removing songs as they complete.

I strongly recommend the Fingertips collection on They Might Be Giant's Apollo 18 for testing this.  Whole pile of 10 second songs.  Great for watching songs end.

Which version of SC are you testing on?  I assume 7.3?  I haven't tried it there at all.
Comment 6 Eric Koldinger 2008-11-04 09:43:12 UTC
Looks like this crashes 7.2.1.
No time to debug now.  More later.
Comment 7 Eric Koldinger 2008-11-12 09:23:32 UTC
Ben,
Found a few minutes to look at this today.
Not sure why this crashed 7.2.1 the other day, but today it seems to work.

Still confuses the Controller, so the bug still appears to be there in 7.2.1.
Comment 8 James Richardson 2008-11-13 09:48:22 UTC
Ben/Eric: Is this still an issue for 7.3?
Comment 9 Eric Koldinger 2008-11-16 16:41:10 UTC
Yes, appears to still be an issue.
Comment 10 Eric Koldinger 2008-11-16 16:43:21 UTC
Also, note, the current version of RemovePlayedSongs (2.2.1) doesn't work correctly on 7.3.
A new version, 2.3, should be appearing on koldware.com/SlimStuff in the near future.
Related to Sync changes.
Comment 11 James Richardson 2009-01-08 09:50:22 UTC
Marking a future as the plugin is not tied to a specific version of SC.  if you feel differently, please comment