Bug 9502 – INPUT.Text truncates valueRef param at first "0" char

Bug 9502 - INPUT.Text truncates valueRef param at first "0" char

Summary:

INPUT.Text truncates valueRef param at first "0" char

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Player UI
Version:	7.2
Platform:	PC Other

Importance:	-- normal (vote)
Target Milestone:	7.x
Assigned To:	Andy Grundman

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-09-15 19:41 UTC by Peter Watkins
Modified:	2009-07-31 10:29 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
patch against SVN that fixes the problem (619 bytes, patch) 2008-09-15 19:41 UTC, Peter Watkins	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Watkins 2008-09-15 19:41:36 UTC

Created attachment 4001 [details]
patch against SVN that fixes the problem

If a plugin pushes into the INPUT.Text mode with a valueRef string that includes a zero character, Slim/Buttons/Input/Text will effectively truncate the string at the first zero. This is due to bad logic that treats "0" characters much like C null characters. SqueezeCenter should use the proper Perl length() API to determine string length and allow zeros in valueRef.

Comment 1 Chris Owens 2008-09-22 10:32:08 UTC

Andy to review the patch and commit.  Thanks, Peter!

Comment 2 Andy Grundman 2008-09-23 09:50:59 UTC

Thanks, applied in 7.2.1 change 23255.

Comment 3 James Richardson 2008-12-15 12:07:45 UTC

This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Comment 4 Chris Owens 2009-07-31 10:29:57 UTC

Reduce number of active targets for SC