Bug 9459 - Redefined strings - increase logging level to Info
: Redefined strings - increase logging level to Info
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Misc
: 7.2
: PC Windows Server 2003
: -- normal (vote)
: 7.x
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-10 16:01 UTC by Jim McAtee
Modified: 2009-07-31 10:29 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
beginning of server.log at startup (1.95 KB, text/plain)
2008-09-23 17:04 UTC, Jim McAtee
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2008-09-10 16:01:02 UTC
I can't see why these need to be logged at the Warn level. (Although I have no idea which log setting controls these log entries, I see them when nothing is set higher than Warn).
Comment 1 James Richardson 2008-09-23 06:15:27 UTC
Andy, care to chime in on this
Comment 2 Andy Grundman 2008-09-23 06:48:21 UTC
Do you mean standard Perl warnings?  Those aren't controlled by the log settings.
Comment 3 Jim McAtee 2008-09-23 17:04:11 UTC
Created attachment 4050 [details]
beginning of server.log at startup

(In reply to comment #2)
> Do you mean standard Perl warnings?  Those aren't controlled by the log
> settings.

I'm not sure I understand what you're asking.  See the attached log.  Are these standard Perl warnings?

I have a custom-strings.txt file and each time SquezeCenter is started every string that's redefined gets logged in the server.log.  String redefinition seems like a fairly basic thing and it all works as expected, so I don't see the need to log them at the default logging levels.
Comment 4 Jim McAtee 2008-09-23 17:12:39 UTC
My apologies for being a lazy***.  Here's the code from Utils::Strings::storeString()  :

if (defined $strings->{$currentLang}->{$name} && defined $curString->{$currentLang} && $strings->{$currentLang}->{$name} ne $curString->{$currentLang}) {
	$log->warn("redefined string: $name in $file");
}

So it would be a matter of changing this to info or debug if you agree that it should be raised.
Comment 5 Michael Herger 2008-10-08 05:43:36 UTC
change 23462
Comment 6 James Richardson 2008-12-15 12:07:36 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 7 Chris Owens 2009-07-31 10:29:48 UTC
Reduce number of active targets for SC