Bug 944 - skin override falls to EN on a case mismatch
: skin override falls to EN on a case mismatch
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.0.0
: PC Windows (legacy)
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-03 12:33 UTC by KDF
Modified: 2008-09-15 14:37 UTC (History)
0 users

See Also:
Category: ---


Attachments
change isSkin to return with proper case (504 bytes, patch)
2005-03-05 01:38 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2005-03-03 12:33:18 UTC
It seems that most skins will work for override without a trailing slash, except
Exbrowse2.  It returns a 404, so I guess the trailing numeric is causeing a
problem with the URL regex matching.
Comment 1 KDF 2005-03-03 22:52:49 UTC
r2314 was a partial fix to allow ExBrowse2 work without a trailing slash, but it
now returns the EN skin instead of a 404.  All skins done by url override seem
to render using EN if the case isn't an exact match.
Comment 2 KDF 2005-03-05 01:38:51 UTC
Created attachment 306 [details]
change isSkin to return with proper case

it seems that a regex match that is case insensitive, puts an all lowercase
match into $1, instead of the actual  matched contents.  Thus, thre is a skin
match, but it doesnt' end up with the right urls to files.

instead, step through each skinname and return the one matched. I can commit
this after it passes a review.
Comment 3 Dan Sully 2005-03-05 12:35:45 UTC
Looks ok.
Comment 4 Chris Owens 2006-06-16 14:41:01 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.