Bug 9438 - Listing playlists, albums or artists in CLI seem to be broken
: Listing playlists, albums or artists in CLI seem to be broken
Status: RESOLVED INVALID
Product: Logitech Media Server
Classification: Unclassified
Component: CLI
: 7.3.0
: PC Windows XP
: -- normal (vote)
: ---
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-08 04:09 UTC by Joggs
Modified: 2008-09-18 11:15 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joggs 2008-09-08 04:09:47 UTC
Listing playlists, albums or artists seem to be broken in latest build (2008-09-08). When Reverting back to 2008-09-07, it works again.

I haven't analyzed the responses but if there is a new format in the responses I guess you should see that in the cli documentation?
Comment 1 Adrian Smith 2008-09-08 13:18:09 UTC
There shouldn't be a new format, but some of the internals have changed - can you describe what you see as different?
Comment 2 Joggs 2008-09-08 23:15:49 UTC
I've built a client that fills some dropdown lists with all artists and
playlists. when i installed the latest build, the lists are empty and when i
revert to earlier version they are filled again
Comment 3 Joggs 2008-09-17 04:59:41 UTC
It still doesn't work.
I don't understand this, it seems like a simple bug, is it just me?

sending <playerid> status 0 99999 tags:Rdlaue ?  doesn't give me a list of all songs in the playlist anymore.

Don't you get the same result?
Comment 4 Adrian Smith 2008-09-17 11:39:50 UTC
Please try with the trailing ? removed:

sending <playerid> status 0 99999 tags:Rdlaue

The old command parser would probably accept trailing "?", but the updated has rewritten this and uses the trailing "?" to index into the internal dispatch table.  This means the cli commands you send should match the definitions given in Slim::Control::Request.pm

The reason for the rewrite was to improve performance - I've tried to make it act in the same way as before, so thanks for the report.  However I couldn't understand it without knowing exactly what the cli command you were sending was.
Comment 5 Joggs 2008-09-18 04:50:02 UTC
Hi,
Yes, it works when removing the question mark. Wonderful.

Maybe the documentation already has these changes. A ? is esay to miss so sorry for the unneccessary hassle if thats the case.

I noticed that some requests still have to end with a question mark such as asking for current playback position ie 'PlayerID + " time ?', so are we going to have a mix of requests where some need trailing ? and some are not, or is the plan to change all of them?

However, you can close this bug report now as it works as it should.
Thank you.
Comment 6 Adrian Smith 2008-09-18 11:15:16 UTC
The docs should already record which queries require a ? and which do not.  All that has changed is that the parser is more stringently implementing the old syntax.  If you look through Slim/Control/Request.pm you can see the definitions of the syntax for each of the build in commands.