Bug 9429 - Rescan music library shows wrong type during scan
: Rescan music library shows wrong type during scan
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.2
: PC Windows Vista
: -- minor (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-07 09:09 UTC by Max Spicer
Modified: 2009-07-31 10:29 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
record scan type in db, show on settings and status pages (3.26 KB, patch)
2008-09-09 12:15 UTC, KDF
Details | Diff
remove a debug (3.07 KB, patch)
2008-09-09 14:23 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Spicer 2008-09-07 09:09:50 UTC
If I select 'clear library and rescan everything' in the web interface then hit Rescan, the drop-down greys out but displays 'look for new and changed music' (the top item in the list) as the selected item.  It does carry out the correct rescan, so this is only cosmetic.  However, it does make it look as if its not doing the requested rescan.

Firefox 3 on Windows Vista.
Comment 1 Michael Herger 2008-09-07 11:33:01 UTC
It's always displaying the default scan type, no matter what you select.
Comment 2 KDF 2008-09-08 13:02:50 UTC
a one-line change in EN/settings/server/basic.html will take care of keeping the selected rescan showing when triggered:

Line 43:
<option [% IF pref_rescantype == option.key %]selected [% END %]value="[% option.key %]">[% option.value | string %]</option>


What this does not do is handle the case where the settings page is accessed directly from the home page settings link.  However, I'd suggest that this is near to pointless.  If for some reason the obsessive types feel it's required, then perhaps store the scan type in the "isScanning" field of the DB instead of just 1/0.  Then you can call that to the page.

Either that, or fold the scheduled rescan plugin into the basic settings pages as core code and universally store the last selected type.  The template can then use that for selecting the default and for showing the current type while scanning.



Comment 3 Michael Herger 2008-09-08 14:31:36 UTC
*** Bug 9386 has been marked as a duplicate of this bug. ***
Comment 4 Philip Meyer 2008-09-08 15:19:52 UTC
It would be good to store the rescan type, for display of the last "music scan details" on the settings status page.
Comment 5 KDF 2008-09-09 12:15:32 UTC
Created attachment 3963 [details]
record scan type in db, show on settings and status pages

shoves the string token into the isScanning metaInformation in the db.  This allows us to compare with the options of the rescan form on the basic settings and show current scan type on status page.  Feel free to rework ui to suit.
Comment 6 KDF 2008-09-09 14:23:47 UTC
Created attachment 3964 [details]
remove a debug

updated version of the patch sans a warning flag I had left in.
Comment 7 Michael Herger 2008-09-23 03:12:40 UTC
change 23243 - thanks kdf!
Comment 8 James Richardson 2008-12-15 12:07:26 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 9 Chris Owens 2009-07-31 10:29:33 UTC
Reduce number of active targets for SC