The proper solution is probably to modify the postinst script to be smart enough to skip the apparmor stuff if it's not installed.  There's no real reason to make apparmor a dependency.

So it seems like maybe we added something to help us with our apparmor problems, but we try it whether or not apparmor is installed.  

Since support gets lots of calls about apparmor, I would say having people install it as a dependency is NOT the right solution.  :)

(In reply to comment #1)
> The proper solution is probably to modify the postinst script to be smart
> enough to skip the apparmor stuff if it's not installed.  There's no real
> reason to make apparmor a dependency.


It should be very straightforward to do.

Change:

		/etc/init.d/apparmor restart

to:
             if [ -x /etc/init.d/apparmor ] then
		/etc/init.d/apparmor restart
             fi

*** Bug 9848 has been marked as a duplicate of this bug. ***

Ross:  can you work with Matt to give him access to an image with AppArmor installed so he can verify the patch.

We already do this check.. in the squeezecenter.postinst code we have this:

        if [ -f /etc/apparmor.d/usr.sbin.mysqld ]; then
                ## Remove the end-bracket so we can input our data into the file...
                sed -e 's/}//' /etc/apparmor.d/usr.sbin.mysqld > /etc/apparmor.d/usr.sbin.mysqld.squeezecenter.new
                echo "  # SqueezeCenter Apparmor Changes for MySqld
  /var/lib/squeezecenter/cache/ r,
  /var/lib/squeezecenter/cache/my.cnf r,
  /var/lib/squeezecenter/cache/mysql.startup rw,
  /var/lib/squeezecenter/cache/mysql-error-log.txt rw,
  /var/lib/squeezecenter/cache/squeezecenter-mysql.pid w,
  /var/lib/squeezecenter/cache/squeezecenter-mysql.sock w,
  /var/lib/squeezecenter/cache/MySQL/ r,
  /var/lib/squeezecenter/cache/MySQL/** rwk,
 } " >> /etc/apparmor.d/usr.sbin.mysqld.squeezecenter.new

                mv /etc/apparmor.d/usr.sbin.mysqld /var/lib/squeezecenter/usr.sbin.mysqld.orig
                mv /etc/apparmor.d/usr.sbin.mysqld.squeezecenter.new /etc/apparmor.d/usr.sbin.mysqld
                /etc/init.d/apparmor restart
                echo "\n"
        fi


We don't modify any files, or restart Apparmor unless we found an apparmor.d directory and the usr.sbin.mysqld file is actually in place. Seems like a pretty good solution to me... 

(In reply to comment #6)
> We already do this check.. in the squeezecenter.postinst code we have this:
>         if [ -f /etc/apparmor.d/usr.sbin.mysqld ]; then
>                 ## Remove the end-bracket so we can input our data into the
> file...
>                 sed -e 's/}//' /etc/apparmor.d/usr.sbin.mysqld >
> /etc/apparmor.d/usr.sbin.mysqld.squeezecenter.new
>                 echo "  # SqueezeCenter Apparmor Changes for MySqld
>   /var/lib/squeezecenter/cache/ r,
>   /var/lib/squeezecenter/cache/my.cnf r,
>   /var/lib/squeezecenter/cache/mysql.startup rw,
>   /var/lib/squeezecenter/cache/mysql-error-log.txt rw,
>   /var/lib/squeezecenter/cache/squeezecenter-mysql.pid w,
>   /var/lib/squeezecenter/cache/squeezecenter-mysql.sock w,
>   /var/lib/squeezecenter/cache/MySQL/ r,
>   /var/lib/squeezecenter/cache/MySQL/** rwk,
>  } " >> /etc/apparmor.d/usr.sbin.mysqld.squeezecenter.new
>                 mv /etc/apparmor.d/usr.sbin.mysqld
> /var/lib/squeezecenter/usr.sbin.mysqld.orig
>                 mv /etc/apparmor.d/usr.sbin.mysqld.squeezecenter.new
> /etc/apparmor.d/usr.sbin.mysqld
>                 /etc/init.d/apparmor restart
>                 echo "\n"
>         fi
> We don't modify any files, or restart Apparmor unless we found an apparmor.d
> directory and the usr.sbin.mysqld file is actually in place. Seems like a
> pretty good solution to me... 


What about a random /etc configuration file implies that a daemon is installed?  

Configuration files are often preserved even after applications are removed, and this is a perfect example.  In fact, the file in question isn't even part of the apparmor deb; it's part of the mysql-server deb.  So you're testing a file from the mysql package to determine if the apparmor application is installed, and not surprisingly, the test falls on its face when apparmor is not present.

A pretty good solution would be to test for /etc/init.d/apparmor before calling it.

Checked in as change #23887. Tested installing MySQL without installing Apparmor and sure enough, it creates the file regardless of whether apparmor is there or not. 

This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Reduce number of active targets for SC