Bugzilla – Bug 942
Live Search song result missing artist and album links.
Last modified: 2008-08-18 10:53:01 UTC
With the default skin, when you "Search Music" in Internet Explorer on XP the search results come up as you type - which is cool. However if you then click on any of the results you are taken to "Browse Genres". If you click on the Search button, then clicking on the search results work as intended and take you to that particular track. And, can someone explain again why I get results like: One Scotch, One Bourbon, One Beer One Bourbon, One Scotch, One Beer One Scotch, One Bourbon, One Beer One Scotch, One Bourbon, One Beer with no Artist, so that I have to click through each link individually to see if it is the track I want? And, shouldnt there be an "Add All to Playlist" option?
On the Advanced Search page there is a "Play" and "Add All to Playlist" option but these are active even when there are no results shown. Thus, pressing "Play" before entering any text will wipe out your current playlist. Pressing "Add All to Playlist" after entering text but before clicking "Search Music" will add all the tracks that have been found but not yet displayed. There are some UI inconsistencies here too - one screen has a "Search" button and one has a "Search Music" button. Given that some people will be more (or exclusively) interested in audiobooks, spoken word etc. and many people will have large collections of music which is not songs, shouldn't all the references to "Song" be changed to "Track" and many of the reference to "Music" removed?
"add all" link is a dupe (bug378), and I'm working on that (at least for manual search, which is what you get when you press the button, or enter). no artist showing up is a skin issue, and depends on TitleFormat as well. I've cleaned that up in the Fishbone skin, so I can do the same for EN and Default. The rest...are up for review. what do you mean when you refer to 'screen'? which skin? also, in future, please try to categorise the bugs as ii means someone else doens't have to come along and change from audio to something more appropriate. It also helps to keep bug reports specific. Broad scopes and multiple issues just make it harder to track in the end. I think there are as many as 5 issues in this one.
oh...actually, I forgot to mention why I'm assigning to Dan. I coudln't see an easy way to get an "add all" link in liveSearch. I dont know if its even possible, or whether it would have to be by category: add all songs, add all artists, etc. feel free to bounce it back to me if you can provide suggestions or a quick patch on that part. I'll likely tackle some parts of this, then create new bugs for the specific parts that may not be done yet.
When I said "screen" I was referring to the Search Music and Advanced Search pages in the default skin. You are correct in pointing out that I should categorise the bugs more and be less broad - there are a lot of bugs in this report and some are general User Interface style issues.
thanks for the clarification. I'm going to assign this to myself and do what I can with the issues here. It should be easy enough to add the usual titleformat styles to the liveseach results. advanced and manual search should already be ok, or at least will be for tomorrow's nightly. I've got most of it done locally. I'll retitle this bug for what's left, or create a new bug if anything else remains outstanding.
ok, I've fixed most of these. search results should show artist and album (depending on titleformat) for manual search and advanced search. live search is hardcoded, so not really possible at this time (maybe post 6.0). submit buttons are more consistent (Search Music). I am not going to get into renaming, becuase that is more of a semantics issue and needs a more open review. add all links should only show if there are results. i'm retitling this bug becuase of the remaining issues: Livesearch results are not infoFormat compatible LiveSearch song links get Browse Genres. String changes for search music => search tracks...i think needs to be filed as a different bug.
Maybe the Songs/Tracks issues are best dealt with by having a setting in the prefs file or by having a different skin, specific to people whose collections are poetry, plays, audiobooks, symphonies, whatever.
I hear ya, but that's a hard one, bart. strings are not skin sensitive. I do agree that search tracks is a better string, but I won't just do it on my own. prefs to set a string would be annoying, to my mind. Lets just let this one sit until things settle a bit. Honestly, if users who are focussed on audiobooks yet still can't handle a 'music' reference are really a minor concern overall. a new skin is a great plan, but that would not fall into bugs either, at least not enough to be left as part of this one. If Dan has some wondredrug for this, great, but if I'm asked to qc the patch on this bug, I'm not going to focus on the strings this time. I can appreciate if you are not happy with that, and I'll expect a new bug report when the time comes :)
I have fixed the song links in live search. These should now work properly in the next nightly build, or update yoru svn to r2325 I will have to discuss with Dan about the album and artist links with the songs. I'm not sure they are really right for this particular case, more specifically I'm not convinced they serve enough purpose to justify the redundant code that has to be added just for this feature.
For me, live search will correctly find albums, but when I click an album it comes up empty (i. e. there are no songs in it). If I search for a song on an album, click that link, and take the album link from there, it works.
Christian - what build are you using?
I've commited a fix for this as subversion change 2473. Livesearch now respects the infoformat.