Bug 9412 - Artist Menu - Play all, All songs and Add to Favorites option problems
: Artist Menu - Play all, All songs and Add to Favorites option problems
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: UI
: unspecified
: PC Windows Vista
: P1 major (vote)
: 7.2.1
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-09-05 14:59 UTC by Ally
Modified: 2008-12-15 12:40 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
this SC patch plus jive >= r2907 should fully fix this bug (2.37 KB, patch)
2008-09-10 16:48 UTC, Ben Klaas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ally 2008-09-05 14:59:35 UTC
Since upgrading the Duet Controller firmware to version 7.2 r2907.
I have now noticed that when displaying your Music Library via the Artists menu the "Play all" , "All songs" and "Add to Favorites" options are no longer highlighted when scrolling through them and the icons for these options now appear to the right of the text.  I think the icon for these were originally display on the left like the album art is.

These 3 options can still be selected even though they do not get highlighted.

The icons for these 3 options move slightly to the right when scrolling through them for the first time.

This display issue is also present when displaying albums via the Years option.

Individual albums can still be selected and tracks are displayed in the next menu as normal.  In this album track list menu the "Play all" and "Add to Favorites" options do not have an icons and so are not effected and function as normal.

I have performed the software update several times but still have this issue.
Comment 1 Ben Klaas 2008-09-05 15:03:05 UTC
For completely unrelated reasons we're going to be rolling back to r2873 (in fact, if you restart your squeezecenter you should get prompted to "upgrade" back to this revision)

This is a valid bug to be fixed though. Assigning to myself for a fix a.s.a.p.
Comment 2 Ben Klaas 2008-09-10 14:26:52 UTC
*** Bug 9439 has been marked as a duplicate of this bug. ***
Comment 3 Ben Klaas 2008-09-10 15:21:50 UTC
SC change 23126, 7.1 branch should fix this for both Podcasts (technically speaking, XMLBrowse items) and Artist Menu items (technically speaking, Slim::Control::Queries items).

There is a remaining issue that this really needs to be paired with SBC firmware r2907 or later, so leaving this open for now.
Comment 4 Ben Klaas 2008-09-10 16:45:34 UTC
<smacks head> should not have checked this into 7.1 branch, as it was the wrong place for it and would actually cause problems there.

Pulled checkin out of 7.1 in change 23130

This really needs to be paired with a firmware change, so it might be correct to hold off on checking this into 7.2 branch until that firmware update is about to be pushed out to users.

I will attach a patch in the meantime...
Comment 5 Ben Klaas 2008-09-10 16:48:17 UTC
Created attachment 3967 [details]
this SC patch plus jive >= r2907 should fully fix this bug
Comment 6 Ben Klaas 2008-09-10 17:39:36 UTC
okay, I think this is sorted now.

r2907 will be pushed to SC 7.2.1 (or updated subversion 7.2 branch) tomorrow
that SBC firwmare, coupled with this change, 7.2 branch SC change 23138, this bug should now be fixed.

whew.
Comment 7 James Richardson 2008-10-14 13:50:02 UTC
Verified fixed in

SqueezeCenter 7.2.1-23555
Controller 7.2 r3080
Comment 8 James Richardson 2008-12-15 12:40:25 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.