Bug 939 - "Standby text size" item "bumps" to the right
: "Standby text size" item "bumps" to the right
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 6.0.0
: PC RedHat Linux
: P2 normal (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-02 18:36 UTC by Jim Knepley
Modified: 2008-08-18 10:54 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
properly disable standby text size setting from player ui (602 bytes, patch)
2005-03-25 12:39 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Knepley 2005-03-02 18:36:54 UTC
In the settings menu, the "Standby text size" menu item doesn't go anywhere when
the right arrow-key is pressed, it just does the "bump" animation.
Comment 1 Robert Moser II 2005-03-03 08:05:19 UTC
I disabled this until we have some way to transparently handle the differences
between the graphics displays and the character-based ones that isn't
mode-dependent.

Options include: 

1)One preference each for active and idle text sizes, regardless of whether the
display is graphic or character (currently we have offDisplaySize and
idleFont_curr for the idle or "off" state, and doublesize/activeFont_curr for
the active or "on" state).  There should only be one font list shared by the two
states in this case.

2)Separate client object methods for getting/setting the active and idle
textsize and font list, independent of active/idle state.

Currently the textsize() method will hide the double preferences from the rest
of the software, but only for the current active/idle state.  Since we will
always be in the active state when changing settings through the player, there
is no way to transparently get or set the idle text size, or to get the idle
font list.
Comment 2 KDF 2005-03-03 11:26:58 UTC
to my mind, it seems reasonable to leave that setting disabled.  Pressing size
when in standby should change the preference just fine, and would relieve the
complication of having the standby setting in active mode.
Comment 3 Dan Sully 2005-03-05 12:18:00 UTC
Do we want to just remove this setting completely?
Comment 4 KDF 2005-03-09 20:05:46 UTC
my vote would be that its not needed. pressing OFF with the remote, then SIZE
takes arguable less button presses than navigating to settings, standby text
size, up/down.
Comment 5 KDF 2005-03-23 18:55:07 UTC
This works as is now, so better to mark it for post 6.0 for a review on whether
the setting should be enabled somehow or have the commented code removed.
Comment 6 KDF 2005-03-25 12:30:49 UTC
*** Bug 1197 has been marked as a duplicate of this bug. ***
Comment 7 Kevin Pearsall 2005-03-25 12:36:31 UTC
pretty useless having it there if it does nothing.
Comment 8 KDF 2005-03-25 12:39:40 UTC
Created attachment 376 [details]
properly disable standby text size setting from player ui

it still appears in the default list, so we need to remove that to fully
disable the setting.
Comment 9 KDF 2005-05-09 21:12:05 UTC
removing the commented code as of change 3152 and closing the bug
turn player off and press SIZE to control the off display size.
Comment 10 Chris Owens 2008-03-11 11:27:59 UTC
This bug was marked resolved in Slimserver 6.1, which is several versions ago.  If you're still seeing this bug, please re-open it.  Thanks!