Bugzilla – Bug 9362
Adding shuffle status to home menu screws up layout
Last modified: 2008-12-15 12:06:48 UTC
I just added shuffle to the root menu of the controller. If now the shuffle option is also displayed on an other page its status will remain at the last position. It seems, that not the whole line will be refreshed until I scroll to the shuffle option again. Added some screenshots. Christian Controller: V7.2 r2873 Server: SqueezeCenter-Version: 7.2 - 22900 @ Tue Aug 26 11:27:23 PDT 2008 - Windows Vista - DE - cp1252 Perl-Version: 5.8.8 MSWin32-x86-multi-thread MySQL-Version: 5.0.22-community-nt
Created attachment 3923 [details] screenshots
eek, that's no good. assigning to myself for fix a.s.a.p.
this is a fairly complicated problem that will likely need some changes in the underlying C code. Assigning to Richard for further assessment.
Richard
I'd propose that in lieu of a real fix that I add some code to CustomizeHomeMenu to disable the ability to promote these problematic items to the home menu. They mess up the UI so badly that I don't feel we should continue pushing out code that supports it. After a real fix I'll pull that code back out. I'll move forward with that proposal unless I hear otherwise.
7.1 r3080 removes the ability to add a "choice" type menu item (e.g., Shuffle and Repeat settings) to the home menu. Until this bug is fixed, I think that's the way it should stay.
Actually I had the problem even before I added Shuffle to the root menu! Sometimes its status remained visible in the root at the top right position next to "music library"... Removing the option to add shuffle to the root menu doesn't solve anything. Christian
It is even easy to reproduce... Go to Settings, scroll up to "Shuffle" scroll down one or two positions, press back "arrow left". Now you will finde the shuffle status top right. Like: Music Library Off Christian
I cannot reproduce the issue with those steps. if you're amenable to it, can either a) factory reset your controller or b) ssh to your controller and remove /usr/share/jive/applets/CustomizeHomeMenu/settings.lua and see if you can still reproduce with the method you just described.
note: you'll need to reboot your controller after removing the settings.lua file, if that's the route you choose to go.
sry, can not reproduce if shuffle is not in root menu. But I am sure I saw shuffle status next to Music Library sometimes before I added it to the root... Christian
Regardless of whether this is reproducible via another path, it is definitely reproducible in the case of adding a choice item to the root menu. This is why I disabled the ability to do so. When the root issue is solved, I'll re-enable. If you find another means of reproducing the problem, I'd like to hear about it. Thanks-
Targeting for 7.3 for the 'real' fix
I've had a look at this, and there is no easy quick fix. The problem is caused because the Choice widget has been used in two different menu widgets, and that is really against the rules. In this case the customize home menu needs to create a copy of the Choice widget to use in the home menu. This needs some more thought. Ok, thought and fixed in r3350.
I'll believe I'll need to re-enable the choice items in CustomizeHomeMenuApplet as well. Re-opening and assigning to myself.
Nope you won't. You only disabled in 7.1/7.2, that change had not got pulled into 7.3. Marking as fixed again.
yep, verfied that it works. most excellent!
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.