Bugzilla – Bug 9305
Player name is not set in player
Last modified: 2008-12-15 12:17:06 UTC
If I connect a player to SC and then change the player name in SC web-interface, the player name gets set in the player itself and sticks even if the player gets disconnected and then reconnects to SC. If I do the same when the player is connected to SN the player name is _not_ set in the player itself, but only in the web-interface. If the player gets disconnected and then reconnects to SN the old player name is shown again.
Andy - is this all we need? I wouldn't want to add the call to $client->prefsInit(), as this might reset the player name to an outdated value when called from elsewhere. Index: /Users/mh/Documents/workspace/SN/lib/SDI/Service/Control.pm =================================================================== --- /Users/mh/Documents/workspace/SN/lib/SDI/Service/Control.pm (revision 4422) +++ /Users/mh/Documents/workspace/SN/lib/SDI/Service/Control.pm (working copy) @@ -365,6 +365,9 @@ Slim::Buttons::Common::pushMode( $client, 'setup.welcome', undef ); } + # write the player name back to the player + $client->setPlayerSetting('playername', $client->name); + # Update the knob as menus may have changed $client->updateKnob(1);
I'm not sure we want to call that every time. I swear I did something like this already, let me find where that code is.
Yeah, there is this code in Slim::Utils::Prefs: if ( main::SLIM_SERVICE ) { # Update players.name database field if name is changed $prefs->setChange( sub { my $name = $_[1]; my $client = $_[2] || return; $client->playerData->name( $name ); $client->playerData->update; # Also update the value in firmware # This is handled by another setChange for playername, # but the prefs code only allows one setChange action per pref $client->setPlayerSetting( playername => $name ); }, 'playername' ); } I think this doesn't take into account the value being changed on the web though. Will test and fix.
Fixed in r4426. Your patch was fine, I just added a check to only run that if the name changes.
This bug has been fixed in the latest release of SqueezeNetwork! If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.