Bug 9277 - ASX Playlists containing RTSP as first URL causes error - suggested fix
: ASX Playlists containing RTSP as first URL causes error - suggested fix
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Formats
: 7.1
: PC Windows XP
: P2 normal (vote)
: 7.x
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-23 15:11 UTC by Patrik Burehall
Modified: 2009-07-31 10:28 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrik Burehall 2008-08-23 15:11:38 UTC
Following a discussion with in the general discussion forum, bpa suggested a quick fix to the problem with ASX playlists containing rtsp as first protocol.

The problem seems to be that the playlist is seen as empty because an URL in rtsp precedes mms and http:
Example:
  <ASX version="3.0">
  <ENTRY>
        <TITLE>Melodikrysset Del 1 av 2</TITLE>
        <ABSTRACT>Melodikrysset - l�dag 23 augusti 2008 12:06</ABSTRACT>
        <REF HREF= "rtsp://lyssna-wm.sr.se/autorec/p4/melodikrysset/srp4riks_2008-08-23_120559_1442_w4.wma"/>
        <REF HREF= "mms://lyssna-wm.sr.se/autorec/p4/melodikrysset/srp4riks_2008-08-23_120559_1442_w4.wma"/>
        <REF HREF= "http://lyssna-wm.sr.se/autorec/p4/melodikrysset/srp4riks_2008-08-23_120559_1442_w4.wma"/>
  </ENTRY>
  <ENTRY>
        <TITLE>Melodikrysset Del 2 av 2</TITLE>
        <ABSTRACT> - l�dag 23 augusti 2008 12:33</ABSTRACT>
        <REF HREF= "rtsp://lyssna-wm.sr.se/autorec/p4/melodikrysset/srp4riks_2008-08-23_123259_1622_w4.wma"/>
        <REF HREF= "mms://lyssna-wm.sr.se/autorec/p4/melodikrysset/srp4riks_2008-08-23_123259_1622_w4.wma"/>
        <REF HREF= "http://lyssna-wm.sr.se/autorec/p4/melodikrysset/srp4riks_2008-08-23_123259_1622_w4.wma"/>
  </ENTRY>
  </ASX>

bpa suggested the following fix (to at least locate the problem):

In the file Slim/Formats/Playlists/ASX.pm Add the line in red to the code starting at line 96:
Code:
---------------------------------------------------------------------------
				REF:
				for my $ref ( @{$refs} ) {
					if ( my $href = $ref->{HREF} ) {
						next if $href !~ /^(http|mms)/i;
						push @entries, {
							title => $title,
							href  => $href,
						};
						
						# Only one link in a REF station should be played
						last REF;
					}
				}
---------------------------------------------------------------------------

I would greatly appreciate if you would care to fix this!

Thanks in advance!

BR
Patrik
Comment 1 Patrik Burehall 2008-08-23 15:13:00 UTC
*** Bug 9273 has been marked as a duplicate of this bug. ***
Comment 2 Patrik Burehall 2008-08-23 15:20:10 UTC
I'm sorry, its getting late here.

Just to make the proposed solution more readable (oviously the added text is not red here, it was a qoutation from the forum: http://forums.slimdevices.com/showthread.php?p=331839&posted=1#post331839)

The added text in line 96 is:
     next if $href !~ /^(http|mms)/i;
above the line "push @entries,..."

So that it just ignores any other protocol than mms or http.

Once again - thanks!

BR
Patrik 
Comment 3 Chris Owens 2008-08-25 09:59:43 UTC
Andy to commit
Comment 4 Andy Grundman 2008-09-02 15:55:36 UTC
Fixed in change 23016.
Comment 5 Patrik Burehall 2008-09-03 14:56:20 UTC
Thanks for great support, and a very good product!

BR
Patrik
Comment 6 Spies Steven 2008-10-14 17:39:34 UTC
Verified with SqueezeCenter Version: 7.2.1 - 23502
Comment 7 James Richardson 2008-12-15 12:35:33 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 8 Chris Owens 2009-07-31 10:28:01 UTC
Reduce number of active targets for SC