Bug 927 - files with embedded cuesheets and external cuesheets produce strange listings
: files with embedded cuesheets and external cuesheets produce strange listings
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Formats
: 6.0.0
: PC All
: P2 normal (vote)
: Future
Assigned To: michael
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-02 12:46 UTC by michael
Modified: 2008-12-15 13:06 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description michael 2005-03-02 12:46:00 UTC
Files that have embedded cuesheets (FLAC files for the most part) and are also
referenced by an external cuesheet will often show listings that are not
completely consistant with either source.

In the event that the two cuesheets differ, the external one should be preferred.
The assumption being that the embedded cuesheet is intended to exactly represent
the original cd for archival purposes. If an external one exists as well, and
differs in content, then the user probably wants these changes to represent her
playback experience. (For example, the external cuesheet may expose "hidden"
bonus tracks or similar.)
Comment 1 Kevin Pearsall 2005-03-23 12:17:58 UTC
can you attach some examples?
Comment 2 michael 2005-03-23 15:35:35 UTC
Many of the reports of having a "track" this is really the whole album are due
to this, as well as some duplicate track reports. That's not even getting into
the issue of cuesheets that intentionally differ. Though I suspect that if your
cuesheets and metadata match perfectly, you won't see anything out of the ordinary.

The thing to do here is when parsing the cuesheet/metadata look to see if the
file being referenced has already been processed. This should actually be pretty
straight forward, but since it's never worked well in the past I wouldn't
consider it a showstopper for 6.0
Comment 3 michael 2005-03-23 20:20:49 UTC
I just took a quick look at this, and it looks like this is going to be trickier
than it looks, unless we fix the recursion in cuesheet parsing first. If we can
do that, this one will be pretty easy.
Comment 4 michael 2005-03-30 17:39:20 UTC
After some through reworking of how cuesheets are parsed, I think I have a fix
for this. It requires a change to updateOrCreate that seems to have caused some
problems in the past, so I want to verify I didn't break anything before committing.
Comment 5 michael 2005-03-31 13:58:46 UTC
revision 2822 should fix this
Comment 6 michael 2005-04-11 17:06:05 UTC
I think this one is finally working right.
Comment 7 James Richardson 2008-12-15 13:06:13 UTC
This bug appears to have been fixed in the latest release!

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Make sure to include the version number of the software you are seeing the error with.