Bug 9252 - Favorites missing in skin inheriting Default
: Favorites missing in skin inheriting Default
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Skins
: 7.2
: PC Windows Server 2003
: P3 normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-21 19:43 UTC by Jim McAtee
Modified: 2009-07-31 10:27 UTC (History)
0 users

See Also:
Category: ---


Attachments
inherited skin (4.78 KB, application/x-zip-compressed)
2008-08-21 19:44 UTC, Jim McAtee
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2008-08-21 19:43:41 UTC
See the zip file for a very simple skin that inherits from the Default skin.  It's missing the Favorites menu item on the home page.
Comment 1 Jim McAtee 2008-08-21 19:44:50 UTC
Created attachment 3864 [details]
inherited skin
Comment 2 Blackketter Dean 2008-08-22 00:02:55 UTC
Michael: this a 7.3 bug or a 7.2.1 bug?
Comment 3 Michael Herger 2008-08-22 00:09:10 UTC
Might be a simple fix. Will investigate.
Comment 4 Michael Herger 2008-08-22 01:40:31 UTC
It's such a stupid little change, I'll do this for 7.2.1:

Index: /Users/mh/Documents/workspace/7.3/server/Slim/Web/Pages/Home.pm
===================================================================
--- /Users/mh/Documents/workspace/7.3/server/Slim/Web/Pages/Home.pm	(revision 22835)
+++ /Users/mh/Documents/workspace/7.3/server/Slim/Web/Pages/Home.pm	(working copy)
@@ -132,8 +132,6 @@
 		Slim::Plugin::DigitalInput::Plugin->webPages($client->hasDigitalIn);
 	}
 
-	# add favorites to first level of Default skin
-	if (($params->{'skinOverride'} || $prefs->get('skin')) eq 'Default') {
 		my $favs = Slim::Utils::Favorites->new($client);
 
 		if ($favs) {
@@ -139,7 +137,6 @@
 		if ($favs) {
 			$params->{'favorites'} = $favs->toplevel;
 		}
-	}
 	
I should never have added that condition. Sorry.
Comment 5 Michael Herger 2008-08-22 05:24:23 UTC
change 22840 (7.2.1) - include Favorites in home menu page of all skins
Comment 6 James Richardson 2008-12-15 12:06:23 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 7 Chris Owens 2009-07-31 10:27:55 UTC
Reduce number of active targets for SC