Bug 9250 - Adjustment of Bass/Treble in Web UI does not actually change audio output of Boom...
: Adjustment of Bass/Treble in Web UI does not actually change audio output of ...
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: PC Other
: P3 major (vote)
: ---
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-21 15:39 UTC by Matt Wise
Modified: 2009-09-08 09:25 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
kdf's patch with the player settings menu using the onChange handler instead of its own subs (1.69 KB, patch)
2008-08-22 01:31 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Wise 2008-08-21 15:39:08 UTC
When you adjust the Bass/Treble in the Web UI of SC, it does not actually seem to adjust the audio output of the player. It does reflect in the player's Bass Treble settings on the Player UI, but the audio itself does not get adjusted. As soon as you make a slight change on the Player UI, the level then adjusts properly.
Comment 1 Matt Wise 2008-08-21 15:53:39 UTC
Works fine on the controller. Michael, can you take a look? 
Comment 2 KDF 2008-08-21 22:30:03 UTC
the audio prefs need a setChange, or you have to call the mixercommand for each from the prefs web handler.  Might be good to handle more of the prefs with setchange (and fix the settings module for these as well, including my mistaken change to use only incremental +/-1 changes)
Comment 3 KDF 2008-08-21 22:31:52 UTC
this will help the web prefs for now:

Index: Slim/Player/Boom.pm
===================================================================
--- Slim/Player/Boom.pm	(revision 22785)
+++ Slim/Player/Boom.pm	(working copy)
@@ -62,6 +62,9 @@
 
 $prefs->setValidate({ 'validator' => 'intlimit', 'low' => 0, 'high' => 100 }, 'lineInLevel');
 $prefs->setChange(\&setLineInLevel, 'lineInLevel');
+$prefs->setChange( sub { $_[2]->bass($_[1]); }, 'bass');
+$prefs->setChange( sub { $_[2]->treble($_[1]); }, 'treble');
+$prefs->setChange( sub { $_[2]->stereoxl($_[1]); }, 'stereoxl');
 
 $prefs->setChange(sub {
 	my ($name, $enabled, $client) = @_;
Comment 4 Michael Herger 2008-08-22 01:00:09 UTC
I've opened a new generic Bug 9253 - add onChange handler to any pref which needs to call some sub on a change. The way this is handled now is prone to errors like this one, because we have to do these calls for all four (player, web, controller, CLI) interfaces.

Thanks kdf - whill work on your patch.
Comment 5 Michael Herger 2008-08-22 01:31:27 UTC
Created attachment 3865 [details]
kdf's patch with the player settings menu using the onChange handler instead of its own subs
Comment 6 Michael Herger 2008-08-22 01:32:20 UTC
Chris/Dean - I need your word on this patch.
Comment 7 Blackketter Dean 2008-08-22 07:07:14 UTC
Looks ok to me.
Comment 8 Michael Herger 2008-08-22 13:25:06 UTC
change 22858 - add change handler to make sure player is updated whenever pref is changed