Bugzilla – Bug 9250
Adjustment of Bass/Treble in Web UI does not actually change audio output of Boom...
Last modified: 2009-09-08 09:25:44 UTC
When you adjust the Bass/Treble in the Web UI of SC, it does not actually seem to adjust the audio output of the player. It does reflect in the player's Bass Treble settings on the Player UI, but the audio itself does not get adjusted. As soon as you make a slight change on the Player UI, the level then adjusts properly.
Works fine on the controller. Michael, can you take a look?
the audio prefs need a setChange, or you have to call the mixercommand for each from the prefs web handler. Might be good to handle more of the prefs with setchange (and fix the settings module for these as well, including my mistaken change to use only incremental +/-1 changes)
this will help the web prefs for now: Index: Slim/Player/Boom.pm =================================================================== --- Slim/Player/Boom.pm (revision 22785) +++ Slim/Player/Boom.pm (working copy) @@ -62,6 +62,9 @@ $prefs->setValidate({ 'validator' => 'intlimit', 'low' => 0, 'high' => 100 }, 'lineInLevel'); $prefs->setChange(\&setLineInLevel, 'lineInLevel'); +$prefs->setChange( sub { $_[2]->bass($_[1]); }, 'bass'); +$prefs->setChange( sub { $_[2]->treble($_[1]); }, 'treble'); +$prefs->setChange( sub { $_[2]->stereoxl($_[1]); }, 'stereoxl'); $prefs->setChange(sub { my ($name, $enabled, $client) = @_;
I've opened a new generic Bug 9253 - add onChange handler to any pref which needs to call some sub on a change. The way this is handled now is prone to errors like this one, because we have to do these calls for all four (player, web, controller, CLI) interfaces. Thanks kdf - whill work on your patch.
Created attachment 3865 [details] kdf's patch with the player settings menu using the onChange handler instead of its own subs
Chris/Dean - I need your word on this patch.
Looks ok to me.
change 22858 - add change handler to make sure player is updated whenever pref is changed