Bug 9240 - MP3::Info : ULT tag should be handled like USLT tag
: MP3::Info : ULT tag should be handled like USLT tag
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Tagging
: unspecified
: PC Other
: P1 normal with 1 vote (vote)
: 7.x
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-21 01:20 UTC by H. Langos
Modified: 2009-09-08 09:21 UTC (History)
0 users

See Also:
Category: ---


Attachments
Short MP3 file that triggers a bug that causes MP3::Info to abort. (97.21 KB, audio/mpeg)
2008-08-21 01:24 UTC, H. Langos
Details
Patch to treat ULT tags like USLT tags MP3/Info.pm (306 bytes, patch)
2008-08-21 01:26 UTC, H. Langos
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description H. Langos 2008-08-21 01:20:21 UTC
This is a bug in the MP3::Info perl module.
I've encountered a MP3 file with id3v2.2.0 tag. 
It has some iso8859 encoded tags but one ULT utf16le tag. It turns out that MP3::Info does not strip the language from that tag before further decoding.
It does for COM, COMM, "COM ", and USLT but somehow ULT was forgotten.

The same omission leaves the second zero terminator of the "Content description" string in the data.

I've checked the latest svn version and based my patch on it but it also applies to the 1.23 Version of MP3::Info as released.
Comment 1 H. Langos 2008-08-21 01:24:46 UTC
Created attachment 3851 [details]
Short MP3 file that triggers a bug that causes MP3::Info to abort.


The complete file can be downloaded at http://chaosradio.ccc.de/cre096.html
The license is: http://creativecommons.org/licenses/by-nc-nd/2.0/de/deed.en

perl -e 'use MP3::Info; use Data::Dumper; MP3::Info::use_mp3_utf8(1); 
$hs = MP3::Info::get_mp3tag("chaosradio_express_096.mp3", 2,2); 
print $_."\n".Dumper($hs);' > 2.2.txt
Comment 2 H. Langos 2008-08-21 01:26:16 UTC
Created attachment 3852 [details]
Patch to treat ULT tags like USLT tags MP3/Info.pm
Comment 3 Blackketter Dean 2008-08-21 08:55:16 UTC
Andy: Can you review for 7.2.1?  Thx.
Comment 4 Andy Grundman 2008-09-23 08:43:01 UTC
Thanks for the patch, applied as 7.2.1 change 23251.
Comment 5 Spies Steven 2008-10-17 15:50:50 UTC
Verified with SqueezeCenter Version: 7.2.1 - 23502
Comment 6 James Richardson 2008-12-15 12:35:32 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 7 Chris Owens 2009-07-31 10:27:54 UTC
Reduce number of active targets for SC