Bug 9199 - Knob should not trigger volume in idle screen saver
: Knob should not trigger volume in idle screen saver
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: PC Windows XP
: -- normal (vote)
: ---
Assigned To: Adrian Smith
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-18 14:48 UTC by sbjaerum
Modified: 2009-09-08 09:30 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sbjaerum 2008-08-18 14:48:38 UTC
I have DateTime as idle screensaver. When turning the knob after this screensaver has kicked in, the volume slider is displayed with accompanying change in volume. Turning the knob should trigger navigation from the idle screensaver.
Comment 1 Blackketter Dean 2008-08-20 11:50:49 UTC
I agree, it shouldn't.

Triode: would this be yours?
Comment 2 Adrian Smith 2008-08-20 12:07:23 UTC
Yes - will need something to exclude this case specifically.  Will look at for 7.2.1
Comment 3 Adrian Smith 2008-08-28 13:21:21 UTC
I can't see a trivial way of implementing this - I think it needs changes to the IR processing logic.

Does the following sound reasonable, and do you think it will break anything:

1) In the map file we define sections for [screensaver], [idlesaver] and [offsaver]
2) When the IR code finds the current mode is SCREENSAVER.* then it uses screensaver/idlesaver/offsaver as as the mode to lookup in the map file (based on the current screensaver mode.
3) By doing this we can have different map entries for the two types of screensaver. 

Otherwise we end up putting special cases in every screensaver.
Comment 4 Blackketter Dean 2008-08-28 13:32:58 UTC
Sounds good to me, Triode.
Comment 5 Andy Grundman 2008-08-28 13:35:57 UTC
I don't know enough about the IR and mode code to know if it will work, so I don't have an opinion. :)
Comment 6 Adrian Smith 2008-08-28 13:48:50 UTC
change 22945

Same idea but I found a way of doing this which extended the current scheme to give a separate map file entry for off, so less changes than originally planned.