Bug 9198 – Make sure ignored items are only ignored from the filesystem's root

Bug 9198 - Make sure ignored items are only ignored from the filesystem's root

Summary:

Make sure ignored items are only ignored from the filesystem's root

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Scanner
Version:	7.2
Platform:	All All

Importance:	P2 normal (vote)
Target Milestone:	7.x
Assigned To:	Michael Herger

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-08-18 13:12 UTC by Michael Herger
Modified:	2009-09-08 09:25 UTC (History)
CC List:	3 users (show)

See Also:
Category:	---

Attachments
allow some file filters to only be applied to certain parent folders (eg. root) (2.89 KB, application/octet-stream) 2008-08-19 05:38 UTC, Michael Herger	Details
remove debug code (2.56 KB, application/octet-stream) 2008-08-19 05:40 UTC, Michael Herger	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Herger 2008-08-18 13:12:05 UTC

%Slim::Utils::Misc::_ignoredItems should only filter out items from the system's root. "Recycled" happens not only to be Windows' trash folder, but an  album by the group Nektar too.

Comment 1 Michael Herger 2008-08-19 05:38:41 UTC

Created attachment 3827 [details]
allow some file filters to only be applied to certain parent folders (eg. root)

Comment 2 Michael Herger 2008-08-19 05:40:14 UTC

Created attachment 3828 [details]
remove debug code

Comment 3 Michael Herger 2008-08-19 05:58:28 UTC

Justin Maggard has pointed out this longstanding issue:

"Thanks Michael.  I saw that area in Misc.pm, but it looked like it would
filter out items located anywhere in the filesystem, and not just in /.
Is that not the case?  I'm just worried someone may have a share
directory named something like "root" or "USB" and this change wouldn't
let them use it."

And he's right: currently it's not possible to have a folder like eg. "Network" or "root" inside your music folder. It will be ignored, even though such albums do exist. The attached patch would fix this issue.

Dean/Chris - is this patch good enough to be checked in to 7.2?

Comment 4 Michael Herger 2008-08-19 08:40:00 UTC

Dean said this was fine for 7.2. Will check in later tonight/tomorrow.

Comment 5 Michael Herger 2008-08-19 14:30:38 UTC

change 22784 - don't filter out all %ignoredItems in all places. Some are only to be filtered when found in a drive's root

Justin - feel free to tune the ReadyNAS specific filter to your needs.

Comment 6 Spies Steven 2008-10-10 15:44:17 UTC

Verified with SqueezeCenter Version: 7.2.1 - 23502

Comment 7 James Richardson 2008-12-15 12:34:59 UTC

This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Comment 8 Chris Owens 2009-07-31 10:27:28 UTC

Reduce number of active targets for SC